From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 675A33840016 for ; Tue, 15 Jun 2021 11:18:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 675A33840016 Received: by mail-ej1-x62e.google.com with SMTP id ce15so21894194ejb.4 for ; Tue, 15 Jun 2021 04:18:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:cc:from:message-id; bh=SR0g4l5CzF3nUJjfvHrwtICCApRO0gNFQmMbDDJvaGg=; b=iAAGC1TFIkXQ+Rg1uxRomdafsGRoui2tI5PhK+5O23idYKI7GeOz2eZhUjBxGlVnMs 37MAbD4qHEokEYuWRXR2PdpLU0bt+GAeBv/oiy9OBSYvCZhxaZ0nKaXPScHcJNLpmCpS 7a4BdxD2YIFOP5S8B5YERsAUyRwVDKZOemz8JMI/yL1K29EAkUOA0P0Mrl113Vjk46lW ysm9aAa/T+Hq0woLHx9TSTaVDS3bunn92cnGiQV4INamUi5+guM53LrOPjPhJsH77h0i JVQ1xXxC4erY2qdUF0GoMDri5Y+mQKmQFV0iHjgV4vp9P2C3l+3txDZBt0CfsGF39WKV PMaw== X-Gm-Message-State: AOAM5304V4oiAAUbX30IvvKiAA3h4K3CA5hBRW3feUxQ3wZasAMj3H02 SZAYCfoXa3UzgMtOdGoagYg= X-Google-Smtp-Source: ABdhPJyB6EvFJFrJ2r2516gtnJOuLP1rohBefam9pZ41ORxEEmjQwRj/m35YhQV3zpUBeIFeJz5kqw== X-Received: by 2002:a17:906:4308:: with SMTP id j8mr20462535ejm.315.1623755936426; Tue, 15 Jun 2021 04:18:56 -0700 (PDT) Received: from [192.168.100.127] (91-119-97-5.dsl.dynamic.surfer.at. [91.119.97.5]) by smtp.gmail.com with ESMTPSA id u12sm11792495edv.43.2021.06.15.04.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jun 2021 04:18:55 -0700 (PDT) Date: Tue, 15 Jun 2021 13:18:54 +0200 In-Reply-To: References: <20210615055922.27205-1-tbsaunde@tbsaunde.org> <20210615055922.27205-4-tbsaunde@tbsaunde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 4/6] return auto_vec from get_dominated_by To: Richard Biener , Richard Biener via Gcc-patches , Trevor Saunders CC: GCC Patches From: Bernhard Reutner-Fischer Message-ID: <857E8A93-10F0-42FA-9BF5-A6A2DF877810@gmail.com> X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2021 11:18:58 -0000 On 15 June 2021 08:46:57 CEST, Richard Biener via Gcc-patches wrote: >On Tue, Jun 15, 2021 at 8:02 AM Trevor Saunders >wrote: >> >> Signed-off-by: Trevor Saunders >> >> bootstrapped and regtested on x86_64-linux-gnu, ok? > >OK=2E > >Thanks, >Richard=2E > >> gcc/ChangeLog: >> >> * dominance=2Ec (get_dominated_by): Return >auto_vec=2E >> * dominance=2Eh (get_dominated_by): Likewise=2E >> * auto-profile=2Ec (afdo_find_equiv_class): Adjust=2E >> * cfgloopmanip=2Ec (duplicate_loop_to_header_edge): Likewise=2E >> * loop-unroll=2Ec (unroll_loop_runtime_iterations): Likewise=2E >> * tree-cfg=2Ec (test_linear_chain): Likewise=2E >> (test_diamond): Likewise=2E >> --- >> diff --git a/gcc/tree-cfg=2Ec b/gcc/tree-cfg=2Ec >> index 02256580c98=2E=2E6bdd1a561fd 100644 >> --- a/gcc/tree-cfg=2Ec >> +++ b/gcc/tree-cfg=2Ec >> @@ -9917,22 +9917,20 @@ test_linear_chain () >> calculate_dominance_info (CDI_DOMINATORS); >> ASSERT_EQ (bb_a, get_immediate_dominator (CDI_DOMINATORS, bb_b)); >> ASSERT_EQ (bb_b, get_immediate_dominator (CDI_DOMINATORS, bb_c)); >> - vec dom_by_b =3D get_dominated_by (CDI_DOMINATORS, >bb_b); >> + auto_vec dom_by_b =3D get_dominated_by (CDI_DOMINATORS, >bb_b); >> ASSERT_EQ (1, dom_by_b=2Elength ()); >> ASSERT_EQ (bb_c, dom_by_b[0]); >> free_dominance_info (CDI_DOMINATORS); >> - dom_by_b=2Erelease (); >> >> /* Similarly for post-dominance: each BB in our chain is >post-dominated >> by the one after it=2E */ >> calculate_dominance_info (CDI_POST_DOMINATORS); >> ASSERT_EQ (bb_b, get_immediate_dominator (CDI_POST_DOMINATORS, >bb_a)); >> ASSERT_EQ (bb_c, get_immediate_dominator (CDI_POST_DOMINATORS, >bb_b)); >> - vec postdom_by_b =3D get_dominated_by >(CDI_POST_DOMINATORS, bb_b); >> + auto_vec postdom_by_b =3D get_dominated_by >(CDI_POST_DOMINATORS, bb_b); >> ASSERT_EQ (1, postdom_by_b=2Elength ()); >> ASSERT_EQ (bb_a, postdom_by_b[0]); >> free_dominance_info (CDI_POST_DOMINATORS); >> - postdom_by_b=2Erelease (); >> >> pop_cfun (); >> } >> @@ -9991,10 +9989,10 @@ test_diamond () >> ASSERT_EQ (bb_a, get_immediate_dominator (CDI_DOMINATORS, bb_b)); >> ASSERT_EQ (bb_a, get_immediate_dominator (CDI_DOMINATORS, bb_c)); >> ASSERT_EQ (bb_a, get_immediate_dominator (CDI_DOMINATORS, bb_d)); >> - vec dom_by_a =3D get_dominated_by (CDI_DOMINATORS, >bb_a); >> + auto_vec dom_by_a =3D get_dominated_by (CDI_DOMINATORS, >bb_a); >> ASSERT_EQ (3, dom_by_a=2Elength ()); /* B, C, D, in some order=2E *= / >> dom_by_a=2Erelease (); I'm curious why you keep the release() above and =2E=2E=2E >> - vec dom_by_b =3D get_dominated_by (CDI_DOMINATORS, >bb_b); >> + auto_vec dom_by_b =3D get_dominated_by (CDI_DOMINATORS, >bb_b); >> ASSERT_EQ (0, dom_by_b=2Elength ()); >> dom_by_b=2Erelease (); here and >> free_dominance_info (CDI_DOMINATORS); >> @@ -10004,10 +10002,10 @@ test_diamond () >> ASSERT_EQ (bb_d, get_immediate_dominator (CDI_POST_DOMINATORS, >bb_a)); >> ASSERT_EQ (bb_d, get_immediate_dominator (CDI_POST_DOMINATORS, >bb_b)); >> ASSERT_EQ (bb_d, get_immediate_dominator (CDI_POST_DOMINATORS, >bb_c)); >> - vec postdom_by_d =3D get_dominated_by >(CDI_POST_DOMINATORS, bb_d); >> + auto_vec postdom_by_d =3D get_dominated_by >(CDI_POST_DOMINATORS, bb_d); >> ASSERT_EQ (3, postdom_by_d=2Elength ()); /* A, B, C in some order=2E= =20 >*/ >> postdom_by_d=2Erelease (); here and=20 >> - vec postdom_by_b =3D get_dominated_by >(CDI_POST_DOMINATORS, bb_b); >> + auto_vec postdom_by_b =3D get_dominated_by >(CDI_POST_DOMINATORS, bb_b); >> ASSERT_EQ (0, postdom_by_b=2Elength ()); >> postdom_by_b=2Erelease (); here? thanks, >> free_dominance_info (CDI_POST_DOMINATORS); >> -- >> 2=2E20=2E1 >>