From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 8714D3858CD1 for ; Wed, 29 Nov 2023 04:46:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8714D3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8714D3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701233184; cv=none; b=DU/4t/NXm9CsM1pI3EFcTC0hAWQ8zMIT9c5PKtTVa6xvC/UjGnu813ACB0WLY6ZDdjpIn14jumcUMCq8fY48Af3yEA1/XT2mwKwruLWiiEfh4o5bqlj9YioAI7DmvO1/gQ+fIoj/XTp4gMP8SfkYPt0n98XvqzV9vR4LhhVkCeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701233184; c=relaxed/simple; bh=wcZdQnZiSmqH1JAUShmOhLjQdVpyYFKnXD7cVGqB6Q4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=henPvC+AcNoR/PSm7FSROpqzLV9DisqxG6PFDTHg2EiwRp/vffBH5/nxqxrXpPDGrU7EAIBFm+TgCZrAW9SnW6tlbD8YhfyqSlGJprD/iany0HXo00I9rzI50GjLA47sXfP0twtLJoQFKEm7VyOxbL3SDFc60POSkEJYrRJ04WE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3b842c1511fso3835714b6e.1 for ; Tue, 28 Nov 2023 20:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701233183; x=1701837983; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HuriLsaK0Dw8OFAuXxoFZCy/5YlY+MWMJeshboxc5Mg=; b=f32WPlDfYnHpBrTINuLEt3r4KE2Wh1sxUpqTDOLB8WesH56lG7lg0g7ZHQZ0JT1VMn uDhqXwqLAoHrTrCGf5ZQoGFPnlH93RzLqbEbDlx08c7GLimHiOZn7zrl8mKt2HfZqH84 YFTaLzcKFc3PqoxkXEF1l1PlQ7qBVtTnozO+pgd0t50zU2iZln5XfgT1/UzMVdjoSJfV VCZf/lK9k1SNpck8Sew7Ik7if/hrLQoXAAtl/BW3hUTT79Nb5cqxDHkqyJivRiXl5Vti 8qUr/YHRjSkaid2RXL/mlP420w9xjLTjrSp6ql2UiHfGfZN5q+hJHV+gvI1aYTEELBpI 2nEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701233183; x=1701837983; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HuriLsaK0Dw8OFAuXxoFZCy/5YlY+MWMJeshboxc5Mg=; b=K86ddwle6HqNwvPoCxswOA1IUrqfeS+WNvnNrdYpHn5hv5WLFFvGvmFXfR2LzVyZky piKh6gDpKboYDRbWwOtFTdRHU/PspTcqeX0miBzJQSF1DgoXJLg0SWJwARt1FF4e/T3h nGWjEcoWkwa9CYc6vfwnaT0KR/gzIgICTFC/XCyWEYyptdfvdOCXAGPcGzdUAFhRCIXf RiGVPG+3mB4obkLXe6lSzWuRd3oOLSAL8S0UvHc3nJXq7t9bvxl4sXFxc7oJMa13AyQV 6YRZqIzsrVUXvSe5uEdDQJsBQ80XXO4yiZaQDv1J+teGchWYEJgGinPic0RMfo+E1jCR DlMA== X-Gm-Message-State: AOJu0YyXQF2x06924tYv5sh8vmaylrXajpbQXGaK0ZaonBHtpFyXqLf8 87O7VGPIq0QuudaEGu8jglo= X-Google-Smtp-Source: AGHT+IG8sPbd40lVP8ll5JBRb07efSek7s4DGq8PWmTQ5jwlEA0uwKyGYOm0Ofez2PbGYZaj8v0vlw== X-Received: by 2002:a05:6808:4d8:b0:3b5:9541:cb43 with SMTP id a24-20020a05680804d800b003b59541cb43mr18710435oie.14.1701233182695; Tue, 28 Nov 2023 20:46:22 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id ca33-20020a056a0206a100b005c200b11b77sm8981698pgb.86.2023.11.28.20.46.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 20:46:22 -0800 (PST) Message-ID: <858e8a77-d0aa-4775-b22d-40536136fe7d@gmail.com> Date: Tue, 28 Nov 2023 21:46:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] [ifcvt] if convert x=c ? y+z : y by RISC-V Zicond like insns Content-Language: en-US To: Fei Gao , gcc-patches Cc: Kito Cheng , Palmer Dabbelt References: <20231030072523.26818-1-gaofei@eswincomputing.com> <20231030072523.26818-3-gaofei@eswincomputing.com> <805ad185-bb70-485c-a806-df5d42455dfb@gmail.com> <20231128105758661692145@eswincomputing.com> From: Jeff Law In-Reply-To: <20231128105758661692145@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/23 19:57, Fei Gao wrote: > 1. In find_if_header function, I found the following piece of codes: > if (!reload_completed && noce_find_if_block(...)), and find_if_header must > be called before noce_try_cond_zero_arith(). Ah good. > > 2. In noce_try_strore_flag_constants, new registers are also generated > without can_create_pseudo_p() check. > > So I guess no need to add can_create_pseudo_p() here. Agreed. I could possibly make an argument that it might be nice to be able to look for these things after reload has completed, but I think we can ignore that for now. Thanks! Jeff