public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Saurabh Jha <saurabh.jha@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Subject: [PATCH] testsuite, arm: Fix up pr112337.c test
Date: Fri, 1 Dec 2023 11:28:48 +0000	[thread overview]
Message-ID: <85bf6edd-748e-492f-a511-3bdb53edf49a@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

Hey,

I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test.

Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this:

"""
Tests that now work, but didn't before (2 tests):

arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors)
arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors)
"""

Ok for trunk? I don't have commit access so could someone please commit on my behalf?

Regards,
Saurabh

gcc/testsuite/ChangeLog:

         * gcc.target/arm/mve/pr112337.c: Fix the testcase

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 816 bytes --]

From 2365aae84de030bbb006edac18c9314812fc657b Mon Sep 17 00:00:00 2001
From: Saurabh Jha <saujha01@e130340.arm.com>
Date: Tue, 28 Nov 2023 13:05:58 +0000
Subject: [PATCH] testsuite: Fix up pr112337.c test

---
 gcc/testsuite/gcc.target/arm/mve/pr112337.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.target/arm/mve/pr112337.c b/gcc/testsuite/gcc.target/arm/mve/pr112337.c
index 8f491990088..d1a075ecd0e 100644
--- a/gcc/testsuite/gcc.target/arm/mve/pr112337.c
+++ b/gcc/testsuite/gcc.target/arm/mve/pr112337.c
@@ -5,8 +5,8 @@
 #include <arm_mve.h>
 
 void g(int32x4_t);
-void f(int, int, int, short, int *p) {
-  int *bias = p;
+void f(int, int, int, short, int32_t *p) {
+  int32_t *bias = p;
   for (;;) {
     int32x4_t d = vldrwq_s32 (p);
     bias += 4;
-- 
2.34.1


             reply	other threads:[~2023-12-01 11:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 11:28 Saurabh Jha [this message]
2023-12-01 12:44 ` Richard Earnshaw (lists)
2023-12-01 13:45   ` Christophe Lyon
2023-12-01 14:10     ` Richard Earnshaw (lists)
2023-12-01 16:46       ` [PATCH v2] " Saurabh Jha
2023-12-03 16:16         ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85bf6edd-748e-492f-a511-3bdb53edf49a@arm.com \
    --to=saurabh.jha@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).