From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 4485D3857C45 for ; Thu, 29 Jun 2023 08:14:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4485D3857C45 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-98e25fa6f5bso54848866b.3 for ; Thu, 29 Jun 2023 01:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688026450; x=1690618450; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=54Lc1MZhy9luQhCtHniMlfnTFyfvYInVX8nvNgAha2M=; b=doHk8zHB2okOvmu586DymPH2qaU7XhHw/qRQHHd/WKgS0ZB1XMYSUgUoLKYhaOorAA R+IA2fV/gPjprjlTFRGE4a2GnbykgdWiCOa+irvDgcjf+TmPIlCmdxGUmx7W4pdsRbkD mtn2KpeB7rRmM0cd1qazIEzxUtM7ebV5vRedNmQC5gzpZPLG5se8ReUAuGWyKa1wUQFP g8WzG0hfgK3IgsYWVkzy4YekjfYin5V0MOAbwEoZ40lsjQGWT7G53jh8D3XH+yWJVH32 R9V7aJG8S5f5LrnCxFwm/kxZs30X08HbAVmI8IIuDeNpB01vfPsCWbud1FTjtvKJ1zGh S3yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688026450; x=1690618450; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=54Lc1MZhy9luQhCtHniMlfnTFyfvYInVX8nvNgAha2M=; b=SQC8yT+ZF6OGdufY35vlp0oiMUGA2fNLOggoialL8phyI0xnn7Du0NC0Hh/HhIrkLJ Gi6fInH3TpFeIo0y74chXR5kmINOU4n/0kOhda4G7u3cVSzQB0/c8UTSuaEyJhkjNDAz tPAYvNl1gb5HNOp4he+OJDxCr47crbT4bgNVTWtZbp+XKiLXXOBd3rlUNYdp09+HTa3z RViVSQQAQI17267/v8OF0lVwCjoU5gizMOroCjYac22+CjRUpUF3n2KUDAMwhWYTJPT1 7odasYBJsWlmWjx+3KjK4+JpplLtADsulbs5tNwMiuRo9p/xPSR0K3dR34txBl/7qpfA bG6g== X-Gm-Message-State: AC+VfDwqC4/Vc4mxicLKGfIpCMMc/KWupuRQ36kA44WfIzpF30J+tsS0 x+pRKANbC+9MpB6yL7L4WT/cW7fAtkw= X-Google-Smtp-Source: ACHHUZ7gX1OTn6/3fOY7/LvUdH+EmtPWz1nOdEvBQwrod6m+a/HYyXa/h04S9ytmAyoQjC8T8JMcqQ== X-Received: by 2002:a17:906:fe0b:b0:96a:3f29:40d9 with SMTP id wy11-20020a170906fe0b00b0096a3f2940d9mr32566742ejb.25.1688026450351; Thu, 29 Jun 2023 01:14:10 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id l16-20020a1709065a9000b00988be3c1d87sm6596581ejq.116.2023.06.29.01.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 01:14:09 -0700 (PDT) Message-ID: <85bfdc0a-6b55-a72c-b8d8-656b40b0003a@gmail.com> Date: Thu, 29 Jun 2023 10:14:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: rdapp.gcc@gmail.com Subject: Re: [PATCH V3] RISC-V: Fix bug of pre-calculated const vector mask for VNx1BI, VNx2BI and VNx4BI To: Robin Dapp via Gcc-patches , =?UTF-8?B?6ZKf5bGF5ZOy?= , Jeff Law , "kito.cheng" , "kito.cheng" , palmer , palmer , richard.sandiford@arm.com References: <20230628094752.332289-1-juzhe.zhong@rivai.ai> <59DD619A76E2AC1A+2023062903025467496516@rivai.ai> <0f48c2b7-a24d-6223-3805-d755c8eb7a7c@gmail.com> Content-Language: en-US From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I grep'ed a bit and found several more instances of the same pattern which would probably all have to be adjusted (frontend-related mostly but also in native_encode_rtx). Most likely they would all have to be adjusted? > Sorry, only realised later, but: if the precision can cover fewer > bytes than the bitsize, I suppose there ought to be some zero-byte > padding at the end as well. It looks like this problem, and also the padding, has been discussed before when the precision of VNx1BI etc. was first adjusted in the RISC-V backend? I didn't immediately get the padding, though. So if we e.g. have a VNx2BI constant {0, 1} what would we pad the resulting value "2" to? A full byte? Juzhe, are we absolutely sure this is the only problem we will have with precision != bitsize and it is confined to the backend? I would not dare to make that call. How does DSE come in here at all as you keep mentioning it? Regards Robin