From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C59843858C27 for ; Wed, 17 Nov 2021 10:06:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C59843858C27 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AH9bNIS005543 for ; Wed, 17 Nov 2021 10:06:28 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ccy6a0kvc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 17 Nov 2021 10:06:28 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1AHA6ScD018919 for ; Wed, 17 Nov 2021 10:06:28 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ccy6a0kuq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Nov 2021 10:06:28 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1AHA3DTg000732; Wed, 17 Nov 2021 10:06:25 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma03ams.nl.ibm.com with ESMTP id 3ca50a8ax4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Nov 2021 10:06:25 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1AHA6NJK197226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Nov 2021 10:06:23 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6FAED52059; Wed, 17 Nov 2021 10:06:23 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.146.131]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id AF22552057; Wed, 17 Nov 2021 10:06:22 +0000 (GMT) Subject: Re: [PATCH 12/15] i386: Fix non-robust split condition in define_insn_and_split To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" References: <7791d23e4be91943d8c6d0ec56493827011e3b96.1636621345.git.linkw@linux.ibm.com> From: "Kewen.Lin" Message-ID: <85c6e57d-ef3d-c9e9-2d79-ee450415d633@linux.ibm.com> Date: Wed, 17 Nov 2021 18:06:21 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: PQ8yB_NZW_ugzhdol6Qbg_yQFt4hCXol X-Proofpoint-ORIG-GUID: m38ekcCFLmUql_3sVu2fISNF1rxHR-Ha X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-17_03,2021-11-17_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 impostorscore=0 clxscore=1015 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111170051 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2021 10:06:31 -0000 Hi Uros, on 2021/11/17 下午3:13, Uros Bizjak wrote: > On Thu, Nov 11, 2021 at 12:25 PM Kewen Lin wrote: >> >> This patch is to fix some non-robust split conditions in some >> define_insn_and_splits, to make each of them applied on top of >> the corresponding condition for define_insn part, otherwise the >> splitting could perform unexpectedly. >> >> gcc/ChangeLog: >> >> * config/i386/i386.md (*add3_doubleword, *addv4_doubleword, >> *addv4_doubleword_1, *sub3_doubleword, >> *subv4_doubleword, *subv4_doubleword_1, >> *add3_doubleword_cc_overflow_1, *divmodsi4_const, >> *neg2_doubleword, *tls_dynamic_gnu2_combine_64_): Fix split >> condition. > > OK. > Thanks! Committed as r12-5334. BR, Kewen > Thanks, > Uros. > >> --- >> gcc/config/i386/i386.md | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md >> index 6eb9de81921..2bd09e502ae 100644 >> --- a/gcc/config/i386/i386.md >> +++ b/gcc/config/i386/i386.md >> @@ -5491,7 +5491,7 @@ (define_insn_and_split "*add3_doubleword" >> (clobber (reg:CC FLAGS_REG))] >> "ix86_binary_operator_ok (PLUS, mode, operands)" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel [(set (reg:CCC FLAGS_REG) >> (compare:CCC >> (plus:DWIH (match_dup 1) (match_dup 2)) >> @@ -6300,7 +6300,7 @@ (define_insn_and_split "*addv4_doubleword" >> (plus: (match_dup 1) (match_dup 2)))] >> "ix86_binary_operator_ok (PLUS, mode, operands)" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel [(set (reg:CCC FLAGS_REG) >> (compare:CCC >> (plus:DWIH (match_dup 1) (match_dup 2)) >> @@ -6347,7 +6347,7 @@ (define_insn_and_split "*addv4_doubleword_1" >> && CONST_SCALAR_INT_P (operands[2]) >> && rtx_equal_p (operands[2], operands[3])" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel [(set (reg:CCC FLAGS_REG) >> (compare:CCC >> (plus:DWIH (match_dup 1) (match_dup 2)) >> @@ -6641,7 +6641,7 @@ (define_insn_and_split "*sub3_doubleword" >> (clobber (reg:CC FLAGS_REG))] >> "ix86_binary_operator_ok (MINUS, mode, operands)" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel [(set (reg:CC FLAGS_REG) >> (compare:CC (match_dup 1) (match_dup 2))) >> (set (match_dup 0) >> @@ -6817,7 +6817,7 @@ (define_insn_and_split "*subv4_doubleword" >> (minus: (match_dup 1) (match_dup 2)))] >> "ix86_binary_operator_ok (MINUS, mode, operands)" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel [(set (reg:CC FLAGS_REG) >> (compare:CC (match_dup 1) (match_dup 2))) >> (set (match_dup 0) >> @@ -6862,7 +6862,7 @@ (define_insn_and_split "*subv4_doubleword_1" >> && CONST_SCALAR_INT_P (operands[2]) >> && rtx_equal_p (operands[2], operands[3])" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel [(set (reg:CC FLAGS_REG) >> (compare:CC (match_dup 1) (match_dup 2))) >> (set (match_dup 0) >> @@ -7542,7 +7542,7 @@ (define_insn_and_split "*add3_doubleword_cc_overflow_1" >> (plus: (match_dup 1) (match_dup 2)))] >> "ix86_binary_operator_ok (PLUS, mode, operands)" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel [(set (reg:CCC FLAGS_REG) >> (compare:CCC >> (plus:DWIH (match_dup 1) (match_dup 2)) >> @@ -9000,7 +9000,7 @@ (define_insn_and_split "*divmodsi4_const" >> (clobber (reg:CC FLAGS_REG))] >> "!optimize_function_for_size_p (cfun)" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(set (match_dup 0) (match_dup 2)) >> (set (match_dup 1) (match_dup 4)) >> (parallel [(set (match_dup 0) >> @@ -10515,7 +10515,7 @@ (define_insn_and_split "*neg2_doubleword" >> (clobber (reg:CC FLAGS_REG))] >> "ix86_unary_operator_ok (NEG, mode, operands)" >> "#" >> - "reload_completed" >> + "&& reload_completed" >> [(parallel >> [(set (reg:CCC FLAGS_REG) >> (ne:CCC (match_dup 1) (const_int 0))) >> @@ -16898,7 +16898,7 @@ (define_insn_and_split "*tls_dynamic_gnu2_combine_64_" >> (clobber (reg:CC FLAGS_REG))] >> "TARGET_64BIT && TARGET_GNU2_TLS" >> "#" >> - "" >> + "&& 1" >> [(set (match_dup 0) (match_dup 4))] >> { >> operands[4] = can_create_pseudo_p () ? gen_reg_rtx (ptr_mode) : operands[0]; >> -- >> 2.27.0 >>