From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id 7D4853858C74 for ; Sun, 19 Nov 2023 21:42:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D4853858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D4853858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700430178; cv=none; b=oHZlvUI3RTkn62svcXQMGGG8vrYFDsVDjN3dqPgHfnNWTskGZBGkeq0GTiihDdH6ePlLmS2cB5PpYBJTPRVo9xBEdpybugpFwQbuHrJi7OnxVU/VORNHWzT0l/05imZNzaKHCZobQo8dBJOfVaNCdBSXrB2dV+MjK6Vj0vQQmDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700430178; c=relaxed/simple; bh=cs/gC4GBCI9LXTN/K7WoMPqYMsLJpNBZavRvhzFml0A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hZ+2Y08emqbyg02nruHemP7slTHHr5vN2BpFbcZltg7tRjl1vROvyEo4HWbTkDP4dHG0HAnocBoTIFIBKJSR2f3cYlHuqxMAdupS+k89HEKXi5c5QTiItoQqnGfdawxWx4Owku8KPiuLDG0AxSVwDw7jUYQjujCsNOJc58q8CqA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1f48ad1700aso1876768fac.1 for ; Sun, 19 Nov 2023 13:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700430176; x=1701034976; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f7NN2if9Kqwi1DniI1xmnebJLMm2pNwCtddVultiHZA=; b=ew+DO7oZr9Mm2m2nsPQNOgKm8uvjf8VX/hbdSHW8tvtCFmG9fewn5iuiDHjStyZ638 6kqKJr7svlkaVlVCFgc7H9/qfjnavif9fs1pOlX2bmkEk5cVe+YjVye8Xx0akw3X1dBF Xz79qkUsVyoiHrmnqDvJptyh7KXtyeJ/neCJq9hdbF1x7X+5fYiqvU00Fs0wiGjanzhQ sCMhSU8xdtpWBli/aRwgFLnyKpzu0seE00yOVz1WJGzzfXV0lT8ImIDTo6HsaVTQYDVc 6JoC8Y/LzvrmNedhRNi5HFTGnAXYSRAmlfLFVhe6dxZmomK3KN5+IkizLhbTssb7Wz/O f6NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700430176; x=1701034976; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7NN2if9Kqwi1DniI1xmnebJLMm2pNwCtddVultiHZA=; b=XgpznGp+Xqcd4hhaeETIqEommjQ4M7gbxhO2Loo16dK8PS7nmH7Rrq2WVk+VmGr05x Ld8WLmbIcB9I0LQH3iQVcvsff76gyqm3xn+yQYVn7IhYm4G0hFAnIbhx/c0lfQ4cjUwd rr/1RIfGGqFeReLvuYInK/+5dVll7ogzJfPmE0jRNP3qnFiL/MpaM1syQMuuE7jdOEP9 uAkUTEF2lHGjGpr2sgO2RNwjZc+Hl/oL5U3G8dxjGSVAr5VoLiKf8FW8ZleMZ/p/oBSM QpxShgtU7uG0D2F/UQ++syBTLSRnCKi1ehJByPhVAT2t6NaZGDp1h+EYUsJGaZeWKDN0 kAQg== X-Gm-Message-State: AOJu0YwOBmQeitgFq2vLHga7Tr/QhHi/8d0lsNDW2Tyf8Eag1+UaGV9n 0U3kZwYz7xq/DpKd3RxmJ6k= X-Google-Smtp-Source: AGHT+IHpvDgVCumF5g8gtOqmGdoZnO6zd+3yix/ysuycknk+VXTCqs7LNd/XEI9pt0h15D8EkICg8A== X-Received: by 2002:a05:6870:1d12:b0:1f5:c70c:aa78 with SMTP id pa18-20020a0568701d1200b001f5c70caa78mr3051974oab.24.1700430175714; Sun, 19 Nov 2023 13:42:55 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id l6-20020a0568301d6600b006c61c098d38sm981009oti.21.2023.11.19.13.42.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 13:42:55 -0800 (PST) Message-ID: <85f8d587-3d6a-4173-9c10-01de61c6919a@gmail.com> Date: Sun, 19 Nov 2023 14:42:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Implement -mmemcpy-strategy= options[PR112537] Content-Language: en-US To: Li Xu , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com, juzhe.zhong@rivai.ai References: <20231117051232.10396-1-xuli1@eswincomputing.com> From: Jeff Law In-Reply-To: <20231117051232.10396-1-xuli1@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/16/23 22:12, Li Xu wrote: > From: xuli > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112537 > > -mmemcpy-strategy=[auto|libcall|scalar|vector] > > auto: Current status, use scalar or vector instructions. > libcall: Always use a library call. > scalar: Only use scalar instructions. > vector: Only use vector instructions. > > PR target/112537 > > gcc/ChangeLog: > > * config/riscv/riscv-opts.h (enum riscv_stringop_strategy_enum): Strategy enum. > * config/riscv/riscv-string.cc (riscv_expand_block_move): Disabled based on options. > (expand_block_move): Ditto. > * config/riscv/riscv.opt: Add -mmemcpy-strategy=. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/base/cpymem-strategy-1.c: New test. > * gcc.target/riscv/rvv/base/cpymem-strategy-2.c: New test. > * gcc.target/riscv/rvv/base/cpymem-strategy-3.c: New test. > * gcc.target/riscv/rvv/base/cpymem-strategy-4.c: New test. > * gcc.target/riscv/rvv/base/cpymem-strategy-5.c: New test. > * gcc.target/riscv/rvv/base/cpymem-strategy.h: New test. This is OK assuming you have tested it to ensure there aren't any regressions in the testsuite. I don't expect problems, but let's be sure :-) Thanks, jeff