From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 13F103858423 for ; Thu, 23 Nov 2023 12:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13F103858423 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13F103858423 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700742278; cv=none; b=jZYBoUdUFVctKbLacG4yjEZViao3B5Kxd2bierIblzgWThglcV8CAUjJ87KLLLNg8FfFZ9FvrJHqFpxJin+UfJn4HpqXehLEKkyuy4XUHXt7QtaMhUL0P/L9RtbaucqfJPyg+W5vRWVjTplBdl6tJ9hIY6kzq4KX1ehAEsnkU2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700742278; c=relaxed/simple; bh=ZEdjMydXIGRmq4fE9ySCorYqjq7bJ3sJv0VS3MArAhE=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=Zwb299W94M7g5mJ1o4bgb4VXUyLx7nVgP0K5ZQmEsRK4PqWE9gDdGPMVSfY9EDbXKhdnMKvAm77HVzuNE74LL4qmp6MAvYbpojjhpA1C2i47BN0e5lzGbTpcPL56p5X5FAaH7aDkYv6HOwCik04j/cRPlw8hFZJxIu158qacLg0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1700742275; bh=ZEdjMydXIGRmq4fE9ySCorYqjq7bJ3sJv0VS3MArAhE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=dQV0FplqMZXpKq7BJd7krvNSDNvENvIjVps7aiwnO4WgdtyI4INgPk/Fpqop4+jNd TE91YbG0ljlbP0ldM+Gd0JPtBjXmQRr0NR0kykBfWFQukRVTS7iW5vuviQ77o49eLZ Ne4xgDJCBjGWFIBxQfOtbrl6YrZWNjyzMF0EPXaw= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 3E73566B39; Thu, 23 Nov 2023 07:24:33 -0500 (EST) Message-ID: <8609363ca71e2a1022678caeddd98d40e415d413.camel@xry111.site> Subject: Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn Date: Thu, 23 Nov 2023 20:24:31 +0800 In-Reply-To: <1d8a856e-d810-3bc9-b985-44c105802bf0@loongson.cn> References: <20231120004728.205167-1-xry111@xry111.site> <20231120004728.205167-5-xry111@xry111.site> <7a4ceec5-2545-f30a-af44-7f7767620b76@loongson.cn> <1d8a856e-d810-3bc9-b985-44c105802bf0@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-11-23 at 17:14 +0800, chenglulu wrote: > When I look at this code and compare it to our scalar implementation, it= =20 > seems >=20 > that our scalar implementation still lacks an "lround". Should be "lroundeven". We don't have an instruction for lround :(. I tried this but it does not work: -(define_int_iterator LRINT [UNSPEC_FTINT UNSPEC_FTINTRM UNSPEC_FTINTRP]) +(define_int_iterator LRINT + [UNSPEC_FTINT UNSPEC_FTINTRM UNSPEC_FTINTRP UNSPEC_FTINTRNE]) (define_int_attr lrint_pattern [(UNSPEC_FTINT "lrint") (UNSPEC_FTINTRM "lfloor") - (UNSPEC_FTINTRP "lceil")]) + (UNSPEC_FTINTRP "lceil") + (UNSPEC_FTINTRNE "lroundeven")]) (define_int_attr lrint_submenmonic [(UNSPEC_FTINT "") (UNSPEC_FTINTRM "rm") - (UNSPEC_FTINTRP "rp")]) + (UNSPEC_FTINTRP "rp") + (UNSPEC_FTINTRNE "rne")]) The problem is "lroundevenMN2" is not a standard pattern name. The SIMD version of ftintrne in patch 1 only works because we are expanding "roundevenM2" (it's a standard pattern name) to UNSPEC_SIMD_FRINTRNE, and then a define_insn can match (fix (UNSPEC_SIMD_FRINTRNE op)). But for non-SIMD we don't have roundevenM2. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University