From: Richard Biener <richard.guenther@gmail.com>
To: Cesar Philippidis
<cesar@codesourcery.com>,"gcc-patches@gcc.gnu.org"
<gcc-patches@gcc.gnu.org>
Subject: Re: inhibit the sincos optimization when the target has sin and cos instructions
Date: Fri, 13 May 2016 19:58:00 -0000 [thread overview]
Message-ID: <862033F1-A268-4236-B908-558C102199B5@gmail.com> (raw)
In-Reply-To: <573628A1.1030501@codesourcery.com>
On May 13, 2016 9:18:57 PM GMT+02:00, Cesar Philippidis <cesar@codesourcery.com> wrote:
>The cse_sincos pass tries to optimize sequences such as
>
> sin (x);
> cos (x);
>
>into a single call to sincos, or cexpi, when available. However, the
>nvptx target has sin and cos instructions, albeit with some loss of
>precision (so it's only enabled with -ffast-math). This patch teaches
>cse_sincos pass to ignore sin, cos and cexpi instructions when the
>target can expand those calls. This yields a 6x speedup in 314.omriq
>from spec accel when running on Nvidia accelerators.
>
>Is this OK for trunk?
Isn't there an optab for sincos? ISTR x87 handles this pass just fine and also can do sin and cos.
Richard.
>Cesar
next prev parent reply other threads:[~2016-05-13 19:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 19:19 Cesar Philippidis
2016-05-13 19:58 ` Richard Biener [this message]
2016-05-13 20:13 ` Andrew Pinski
2016-05-17 21:10 ` Cesar Philippidis
2016-05-17 21:23 ` Andrew Pinski
2016-05-17 21:30 ` Cesar Philippidis
2016-05-18 12:29 ` Nathan Sidwell
2016-05-19 3:43 ` Cesar Philippidis
2016-05-19 11:29 ` Alexander Monakov
2016-05-19 18:42 ` Cesar Philippidis
2016-05-19 23:30 ` Nathan Sidwell
2016-05-19 23:12 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=862033F1-A268-4236-B908-558C102199B5@gmail.com \
--to=richard.guenther@gmail.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).