[PATCH][ARM] testsuite, use arm_eabi #3

[PATCH][ARM] testsuite, use arm_eabi #3

[Andreas Tobler]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

another one. Here I'm not really sure if there are EABI variants which 
do _not_ support these test cases.

My target succeeds with this patch.

Comments?

If no (comments), ok for trunk?

TIA,
Andreas

2014-11-10  Andreas Tobler  <andreast@gcc.gnu.org>

	* g++.old-deja/g++.jason/enum6.C: Use arm_eabi for dg-options.
	Update comment.
	* g++.old-deja/g++.law/enum9.C: Likewise.
	* g++.old-deja/g++.other/enum4.C: Likewise.


[-- Attachment #2: arm_fbsd_test3.diff --]
[-- Type: text/plain, Size: 2483 bytes --]

Index: g++.old-deja/g++.jason/enum6.C
===================================================================
--- g++.old-deja/g++.jason/enum6.C	(revision 217306)
+++ g++.old-deja/g++.jason/enum6.C	(working copy)
@@ -7,10 +7,8 @@
 // enum-size attributes should only be emitted if there are values of
 // enum type that can escape the compilation unit, gcc cannot currently
 // detect this; if this facility is added then this linker option should
-// not be needed.  arm-*-linux* should be a good approximation to
-// those platforms where the EABI supplement defines enum values to be
-// 32 bits wide.
-// { dg-options "-fshort-enums -Wl,--no-enum-size-warning" { target arm*-*-linux* } }
+// not be needed.
+// { dg-options "-fshort-enums -Wl,--no-enum-size-warning" { target arm_eabi } }
 
 #include <limits.h>
 
Index: g++.old-deja/g++.law/enum9.C
===================================================================
--- g++.old-deja/g++.law/enum9.C	(revision 217306)
+++ g++.old-deja/g++.law/enum9.C	(working copy)
@@ -7,10 +7,8 @@
 // enum-size attributes should only be emitted if there are values of
 // enum type that can escape the compilation unit, gcc cannot currently
 // detect this; if this facility is added then this linker option should
-// not be needed.  arm-*-linux* should be a good approximation to
-// those platforms where the EABI supplement defines enum values to be
-// 32 bits wide.
-// { dg-options "-fshort-enums -Wl,--no-enum-size-warning" { target arm*-*-linux* } }
+// not be needed.
+// { dg-options "-fshort-enums -Wl,--no-enum-size-warning" { target arm_eabi } }
 
 // GROUPS passed enums
   extern "C" int printf (const char *, ...);
Index: g++.old-deja/g++.other/enum4.C
===================================================================
--- g++.old-deja/g++.other/enum4.C	(revision 217306)
+++ g++.old-deja/g++.other/enum4.C	(working copy)
@@ -9,10 +9,8 @@
 // enum-size attributes should only be emitted if there are values of
 // enum type that can escape the compilation unit, gcc cannot currently
 // detect this; if this facility is added then this linker option should
-// not be needed.  arm-*-linux* should be a good approximation to
-// those platforms where the EABI supplement defines enum values to be
-// 32 bits wide.
-// { dg-options "-fshort-enums -Wl,--no-enum-size-warning" { target arm*-*-linux* } }
+// not be needed.
+// { dg-options "-fshort-enums -Wl,--no-enum-size-warning" { target arm_eabi } }
 
 enum E { 
   a = -312

Re: [PATCH][ARM] testsuite, use arm_eabi #3

[Mike Stump]

On Nov 10, 2014, at 2:06 PM, Andreas Tobler <andreast-list@fgznet.ch> wrote:
> another one. Here I'm not really sure if there are EABI variants which do _not_ support these test cases.

I think the patch is fine, just watch for any follow-on comments from an eabi/arm expert.  Usually they are pretty responsive.

Re: [PATCH][ARM] testsuite, use arm_eabi #3

[Andreas Tobler]

On 11.11.14 00:45, Mike Stump wrote:
> On Nov 10, 2014, at 2:06 PM, Andreas Tobler <andreast-list@fgznet.ch> wrote:
>> another one. Here I'm not really sure if there are EABI variants which do _not_ support these test cases.
>
> I think the patch is fine, just watch for any follow-on comments from an eabi/arm expert.  Usually they are pretty responsive.
>

Thanks.

I got not comment since 14 days, so I did the commit.

https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg01087.html

Andreas