From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id DA6A23858C39 for ; Tue, 7 Mar 2023 14:34:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA6A23858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CADFE1FE18; Tue, 7 Mar 2023 14:34:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678199654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOpuRgaBhRn5lydKHuhvS9lUsdSWgceZjQQTzkGz4Wc=; b=iuLw/zz2V/EJYm40FWSPdJWxPYXSsHhUMtNquOEdDW0enFiisLBdBSpL2j9SokfNKRr/Tl THYxJD+i1O8SS8QHeYr8Rl+2SgPUC3NFWoSuivxI9yh2mCaM/+roY+YrbAOokSQZAi7YWk MqdgU8C37djKv1xfY3xKqtbQ84B6Cag= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678199654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOpuRgaBhRn5lydKHuhvS9lUsdSWgceZjQQTzkGz4Wc=; b=iRlT7imTpJQy1tz2BdHw0EWfkUqnQUilKWge59rAriufW01QZcNepJomt5aF/xmW9LjHo9 ZNg3f394EWzFSeCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC7961341F; Tue, 7 Mar 2023 14:34:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YL/DKGZLB2RFAQAAMHmgww (envelope-from ); Tue, 07 Mar 2023 14:34:14 +0000 Message-ID: <863a2969-d242-9dd0-e0cb-2582c0997973@suse.cz> Date: Tue, 7 Mar 2023 15:34:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Ping: [PATCH 1/2] testsuite: Provide means to regexp in multiline patterns Content-Language: en-US To: Hans-Peter Nilsson , Mike Stump Cc: gcc-patches@gcc.gnu.org References: <20230224191603.3935F20447@pchp3.se.axis.com> <20230304015825.56CC220420@pchp3.se.axis.com> <20230307003213.B90CC20405@pchp3.se.axis.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20230307003213.B90CC20405@pchp3.se.axis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/7/23 01:32, Hans-Peter Nilsson wrote: >> From: Mike Stump >> Date: Mon, 6 Mar 2023 02:05:35 -0800 > >> Ok > > Thanks! The server-side hook didn't like my ChangeLog > entry: > > * lib/multiline.exp (_build_multiline_regex): Map > "{re:" to "(", ":re}" to ")" and ":re?}" to ")?". > > It seems I forgot to validate that patch by > contrib/gcc-changelog/git_check_commit.py, which complains: > > Checking c0debd6f586ef76f1ceabfed11d7eaf8f6d1b110: FAILED > ERR: bad wrapping of parenthesis: " "{re:" to "(", ":re}" to ")" and ":re?}" to ")?"." Hello. Yeah, that's quite interesting problem ;) > > I gave in and took the easy way out; not fixing the bug in > that script, but instead "wrapped the parenthesis" to: > > * lib/multiline.exp (_build_multiline_regex): Map > "{re:" to "(", similarly ")?" from ":re?}" and the > same without question mark. > > I hope to make amends by fixing git_check_commit.py, if > given guidance. Sure, you can take a look at: contrib/gcc-changelog/git_commit.py::process_parentheses where we might want to skip the stack push/pop if the character is wrapper in apostrophes or double quotes. Martin > > brgds, H-P