From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by sourceware.org (Postfix) with ESMTPS id 0FAA5384AB58 for ; Fri, 3 May 2024 16:41:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FAA5384AB58 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0FAA5384AB58 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714754489; cv=none; b=D0ssaypdvgPCFTtJo1mVdtLMcpzEmMefNeGwvUs3kGECw48DWOmJThwjWgjwCw0KNvuFgQd/Ho5Aeo7mIWGFHu1JfwnkcbI6tzkyuNufsmp6V/c12LOtbsufftKFFvb+YzUCK/jC0KKjSXeaYUZlyka/XQTRTZRdnJNq6xnShf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714754489; c=relaxed/simple; bh=wus3i02srukVtIpnqvDU1lhaRDq3+Z/LOStMPaOY5po=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=PSanSZ1vsjETJ4FfSPBwAZNYHbsFOQF8qKsEwReoXypAp6O7UXV03pitAVo43Mofgoen/+VROZsy3QjbgvUV2uMxFvRDH5cIWO8You+kvvKypj6hPAo4RZJjN0dDU+CkB/SllU2YTl7K7uOnxL4oygcoYRjf0oVf5gyfyKNWDhw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-5aa17c29ba0so5901896eaf.3 for ; Fri, 03 May 2024 09:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1714754487; x=1715359287; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S8nVDJ/ZniyjRi46IQcXTR2OXzE0y8B9iU9FkOWe4Ug=; b=dsvewux3ltGlw2hPbi2CDJfpwmadnC4Hu65q5g1E/iMamfjAdK0VQ3fhR6/IDYnB4N JT0lvRdr/hx4m57Gv2Q/dvLGPySsttHXNFPgnMnaBMuEdkOFBT5P/SyGpNkNbEwIMP98 nlQhHnCZlkad/k9gCAj2+nCKhq5SDGH7aeZLqzNzBdhAfIA/4i12NodDWwKN6YGPc2vJ 75QrCac9jjpS2WiRYIJFSZqA+r3bLZYM9nnTjFr3fPaobpiOlPy2WDL2Kt5APGQTrmn2 rTgIeYpap8WbBatq8wyoqK4ZSgBfdH5dT6tVdAAxEOUvCmTEuqCpcgJJQHyZEU8/kWIj hX3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714754487; x=1715359287; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S8nVDJ/ZniyjRi46IQcXTR2OXzE0y8B9iU9FkOWe4Ug=; b=ttKoalTl8gq9/uoGv2HtxKQ0V6TOLlDLeSq1geK9gUCSKDaONfXLvpmg6EAwzj76hK CySNV2TCd5AGK/13AzKwmWO/UfheHXz8LwFLxCdkle9rQaMVw7qnTrtttIJ3EU9Od5BU muDu2anW98QTWmskQL2DcS0QdS+6Mp2BMtFlL0DEDKYN9jSndKpjxzQRKYw8lRoCwCwF NMgmpgsmWLpUpL1FCsnRrhIEOBXIiGXXfl3AL9Gg32quqJenVLgwc3G+ndraJYFtmrPM x8g22EdyDW8vef9rz9py7cv/9T5V5VWgcNXR5/FeotCGF59GCosOkVYV7yY1f06D3nU0 LI7g== X-Gm-Message-State: AOJu0YzANhrkHV2pt0m/GZkEu44ZKq8q8277rGb9fLmHTi9c49O6ronr 9ovuXLdTHAFTfK1zDBhowUx07Le6CUHVE4F8sjS41D31vR+aoBIZCEXohVnj7Jc= X-Google-Smtp-Source: AGHT+IGKhqiTI3L2jOkgPrNQJxoOFkXMP9xn34AQxb8vLVcXQ+VXUEHV4LwTKDH4rq/yb/an1w0FWw== X-Received: by 2002:a05:6358:3110:b0:18f:81e1:dc33 with SMTP id c16-20020a056358311000b0018f81e1dc33mr3941431rwe.2.1714754487146; Fri, 03 May 2024 09:41:27 -0700 (PDT) Received: from [192.168.50.117] (c-24-5-188-125.hsd1.ca.comcast.net. [24.5.188.125]) by smtp.gmail.com with ESMTPSA id cl7-20020a056a02098700b005fd607e38e3sm2989459pgb.4.2024.05.03.09.41.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 May 2024 09:41:26 -0700 (PDT) Message-ID: <86765e51-9b57-422e-b6a4-59c7b9e8ca98@rivosinc.com> Date: Fri, 3 May 2024 09:41:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] combine: initialize a local var To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, Jeff Law , kito.cheng@gmail.com, Palmer Dabbelt , Robin Dapp , gnu-toolchain@rivosinc.com References: <20240502185924.2060196-1-vineetg@rivosinc.com> <20240502185924.2060196-4-vineetg@rivosinc.com> <20240503082658.GU19790@gate.crashing.org> Content-Language: en-US From: Vineet Gupta In-Reply-To: <20240503082658.GU19790@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/3/24 01:26, Segher Boessenkool wrote: > On Thu, May 02, 2024 at 11:59:24AM -0700, Vineet Gupta wrote: >> This is no logic change (but technically still a functional change). > Where are 1/3 and 2/3? Or are those unrelated? Yes they were unrelated (minor doc fixes) hence didn't want to spam you, but you are right just because they were piled up in my spring cleaning branch doesn't mean I send them out that way. > Please don't make series like that. Noted for future. > >> Ran into this when stepping thru combine code. >> @newpat has some random garbage for a bit until it is actually set. >> With the fix it remains 0 until actually set. > The same is true for all uninitialised variables. Setting everything > to zero explicitly is a) quite a bit slower, and b) just as wrong! > For example, here, newpat should never be zero. Never. It does not > make any sense. > > Is there any place where newpat is used uninitialised? As I mentioned this patch was the outcome of my "debugging" experience and agree I should not conflate between what the compiler does and what is needed to debug the compiler itself. I've dropped this one. Thx, -Vineet