From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [IPv6:2001:67c:2050:0:465::103]) by sourceware.org (Postfix) with ESMTPS id 4B5353858D1E for ; Sat, 11 Mar 2023 20:22:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B5353858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4PYvV44xQbz9slM; Sat, 11 Mar 2023 21:22:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1678566140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=49x9ih/Oz/FKcrE9l8TJg1UlvR1QqCHlhVeRD+3sdbc=; b=idLRP+WwYyTQW0TSO0iv13v7k7mZQN7l7DaBv3Qzlkoa/wQYisrU7piLtTy67QGRUePea+ NuR91Ec+BBDZNFZr2LIOrH7dbhyO98dj2Uq6ZXkX6L4TVYmZ8sPXEqwZtOnwj7WOLV0htl ITOQ9qc6mla+MhUW156e0rG9EqOBngLZRNqqeGci9NjwKsQenflwJ6dJBBqAZ+DJMLPbPV EQiD38cDp35aG7wjQkmzfJ9/fTfUyZderlewwMMVNqmrd0i9ARmrEAalFH03C24Y4/KeQ+ RO/bvvB3rxNOMWsjyQdhTjdEaHI5nl792UmuEkWZ6PtAgLqc2npjjzIc7puk6w== References: <20230223102714.3606058-1-arsen@aarsen.me> <20230223102714.3606058-2-arsen@aarsen.me> <9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com> <86sfed63l6.fsf@aarsen.me> <1db33a21-4645-1c63-faf2-4048be07c323@siemens.com> <86356b1nnh.fsf@aarsen.me> <524da6ec-f5b5-c41d-a96f-2481ffe3c5d6@siemens.com> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Sandra Loosemore Cc: Sandra Loosemore , gcc-patches@gcc.gnu.org, Gerald Pfeifer , Joseph Myers Subject: Re: [PATCH v2 1/5] docs: Create Indices appendix Date: Sat, 11 Mar 2023 21:14:19 +0100 In-reply-to: <524da6ec-f5b5-c41d-a96f-2481ffe3c5d6@siemens.com> Message-ID: <868rg3xclp.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sandra Loosemore writes: > On 3/11/23 05:22, Arsen Arsenovi=C4=87 wrote: >> OK, changed up a bit, what do you think of this: >> maintainer-scripts/ChangeLog: >> * update_web_docs_git: Set CONTENTS_OUTPUT_LOCATION=3Dinline in >> order to put @shortcontents above contents. See >> 9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com on >> gcc-patches. >> gcc/ChangeLog: >> * configure.ac: Add check for the Texinfo 6.8 >> CONTENTS_OUTPUT_LOCATION customization variable and set it if >> supported. >> * configure: Regenerate. >> * Makefile.in (MAKEINFO_TOC_INLINE_FLAG): New variable. Set by >> configure.ac to -c CONTENTS_OUTPUT_LOCATION=3Dinline if >> CONTENTS_OUTPUT_LOCATION support is detected, empty otherwise. >> ($(build_htmldir)/%/index.html): Pass MAKEINFO_TOC_INLINE_FLAG. >> See 9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com on >> gcc-patches. > > Hmmm, first off, I think somebody other than me needs to approve the conf= igure > and makefile pieces, as well as the maintainer-scripts part. It looks > conceptually right to me, although I would add a comment to new configure= .ac > piece like > > "Newer versions of Texinfo put the table of contents in the wrong place by > default in HTML output, but provide a command-line option to restore the > desired behavior. Check whether we need to do that." This sounds good, will drop in. Who can review these? > I don't know whether the maintainer-scripts change needs to be made condi= tional > too. :-S I don't think so, I was thinking of omitting it for the usual build too since it's a nonfatal error to pass non-existent customization variables, but I decided that this would introduce too much noise to the normal path. This shouldn't emit a warning on the server that runs the update anyway since, hopefully, we'd be updating it 7.0dev for the other goodies. > BTW, this change probably needs to be backported to all active GCC branch= es > (10, 11, and 12) too after it's committed to mainline. I'm not opposed to doing that. > -Sandra =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZAzi8l8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosST/4QA/iSIiWLALrhWhe2wxpRb94eU48ibh5oIqoYP TnA/JjLJAPwPSza4al54mTkvMY3Vf4O7EGHbZjF6uBuQ/EEk+pZmDw== =KiN5 -----END PGP SIGNATURE----- --=-=-=--