From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 49F483858D28 for ; Fri, 1 Jul 2022 15:53:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49F483858D28 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D1B7113E; Fri, 1 Jul 2022 08:53:06 -0700 (PDT) Received: from [10.2.78.56] (unknown [10.2.78.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4BB633F66F; Fri, 1 Jul 2022 08:53:05 -0700 (PDT) Message-ID: <86c3f130-a5f5-0ac5-854c-37d918b33895@foss.arm.com> Date: Fri, 1 Jul 2022 16:53:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 11/12] aarch64: Make bti pass generic so it can be used by the arm backend Content-Language: en-GB To: Andrea Corallo , Andrea Corallo via Gcc-patches Cc: Richard Earnshaw , nd References: From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3490.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 15:53:07 -0000 On 28/04/2022 10:51, Andrea Corallo via Gcc-patches wrote: > Hi all, > > this patch splits and restructures the aarch64 bti pass code in order > to have it usable by the arm backend as well. These changes have no > functional impact. > > Best Regards > > Andrea > > gcc/Changelog > > * config.gcc (aarch64*-*-*): Rename 'aarch64-bti-insert.o' into > 'aarch-bti-insert.o'. > * config/aarch64/aarch64-protos.h: Remove 'aarch64_bti_enabled' > proto. > * config/aarch64/aarch64.cc (aarch_bti_enabled): Rename. > (aarch_bti_j_insn_p, aarch_pac_insn_p): New functions. > (aarch64_output_mi_thunk) > (aarch64_print_patchable_function_entry) > (aarch64_file_end_indicate_exec_stack): Update renamed function > calls to renamed functions. > * config/aarch64/t-aarch64 (aarch-bti-insert.o): Update target. > * config/arm/aarch-bti-insert.cc: New file including and > generalizing code from aarch64-bti-insert.cc. > * config/arm/aarch-common-protos.h: Update. > * config/arm/arm-passes.def: New file. > Is this patch fully stand-alone? It adds arm-passes.def, which adds a reference to pass_insert_bti, but that isn't fully wired up until the next patch. R.