From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 110D13858D28 for ; Thu, 25 May 2023 07:25:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 110D13858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34P7LuiU030226 for ; Thu, 25 May 2023 07:25:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=leh37fuWNeJnEkvhBGyAHCgtwdKEJ5lYQd5h24tjggU=; b=PgKgP5LmW7C+LMpf8JMjOx6Qqf4/QOjyVw/t8zUUJ4ppyHHoU6Pzl7PU8fwO7CfG0IxJ V7nhcywDOcifaOOCWN5SWYywlhF4GiBPyUBqsKEIK6NlrCXrv+tASSrgPCwX1FW8t/76 REe5h6QJhJiD8F50uQy/JpKc3u9ol3b+o6w3gYqW2sBZK6IMJ5Na5+2fwJZ/UApFPqKU prJU/qXOrSG1jdwS3UPRnJeLTcIZG8bN+YpNqoPq/Bha2k9lPbYE/w0pHoVk5t+oGMDD CSmqcPB9a6MUxZnhofwsynkwsnidFslP0SkfEa1eC8NRXEs6qrUUQsAG2u+dsEzjUcIC tA== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qt37mg2jv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 May 2023 07:25:45 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34OKgfeF005648 for ; Thu, 25 May 2023 07:25:43 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3qppc3jajg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 May 2023 07:25:43 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34P7Pe0846268740 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 May 2023 07:25:40 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E88620043; Thu, 25 May 2023 07:25:40 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E483420040; Thu, 25 May 2023 07:25:39 +0000 (GMT) Received: from [9.152.224.246] (unknown [9.152.224.246]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 25 May 2023 07:25:39 +0000 (GMT) Message-ID: <86d73007-692c-51b4-d6a6-fc9265187141@linux.ibm.com> Date: Thu, 25 May 2023 09:25:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] libgcc: Use initarray section type for .init_stack To: "Kewen.Lin" , GCC Patches References: <050edd6f-0ad9-fbad-a9e5-03ec7b937971@linux.ibm.com> Content-Language: en-US From: Andreas Krebbel In-Reply-To: <050edd6f-0ad9-fbad-a9e5-03ec7b937971@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: k5__WWKvI0O5qxPSyE4BDbuUhMhIoKk- X-Proofpoint-ORIG-GUID: k5__WWKvI0O5qxPSyE4BDbuUhMhIoKk- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-25_03,2023-05-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 mlxscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305250057 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/20/23 07:33, Kewen.Lin wrote: > Hi, > > One of my workmates found there is a warning like: > > libgcc/config/rs6000/morestack.S:402: Warning: ignoring > incorrect section type for .init_array.00000 > > when compiling libgcc/config/rs6000/morestack.S. > > Since commit r13-6545 touched that file recently, which was > suspected to be responsible for this warning, I did some > investigation and found this is a warning staying for a long > time. For section .init_stack*, it's preferred to use > section type SHT_INIT_ARRAY. So this patch is use > "@init_array" to replace "@progbits". > > Although the warning is trivial, Segher suggested me to > post this to fix it, in order to avoid any possible > misunderstanding/confusion on the warning. > > As Alan confirmed, this doesn't require a premise check > on if the existing binutils supports "@init_array" or not, > "because if you want split-stack to work, you must link > with gold, any version of binutils that has gold has an > assembler that understands @init_array". (Thanks Alan!) > > Bootstrapped and regtested on x86_64-redhat-linux > and powerpc64{,le}-linux-gnu. > > Is it ok for trunk when next stage 1 comes? > > BR, > Kewen > ----- > libgcc/ChangeLog: > > * config/i386/morestack.S: Use @init_array rather than > @progbits for section type of section .init_array. > * config/rs6000/morestack.S: Likewise. > * config/s390/morestack.S: Likewise. s390 parts are ok. I did run a bootstrap and regression. Looks all good. Thanks! Andreas