From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 9E2BE3858D39 for ; Thu, 27 Jul 2023 14:43:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E2BE3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686efb9ee0cso1049093b3a.3 for ; Thu, 27 Jul 2023 07:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690469014; x=1691073814; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VO6NvhvOZeDjC+Rxl5qmTp4S+mb6+nZidqAaN0t+di8=; b=B7ZQ4C6vZUnGWmrgBldXcRp/aBT3qtbS6OKlKthlFmp1DevrxuwUYulD0bThZp2mSP 4tse7TjS2n7tBKEM4E9qSOofUQuUASzRGXrEAG3m88/e9pDYuEWqqNzej7yDkgo0nxDs XbVT56mokhzSkn8S51SSlMUgYO3uWjMu4k04ZeLOcYF5PnXMHsI/s9dbhxwxCPfn2ISR jbx3dCWaS4UQ8q5Dsxc62yKPfnzDjYFPXujtwNhVIxZ8tqssszxkBXwxJBmUU5TcQHKC Orv65LZw2f7lro/rwBxJfDrTW+tn/3d+zD2J4+ZRs5uKzxr37SxkmFYgqslY/2HWvicH byxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690469014; x=1691073814; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VO6NvhvOZeDjC+Rxl5qmTp4S+mb6+nZidqAaN0t+di8=; b=lEul2GPmfpUTbAgx/RcXzrKo3diJ8ip50+zyVFqk3nxpBoffrNJatjHCpFJMBSfB11 ot0gDYKsQp//gULOGoyFFXYbUnr3SDU6N0M/NCFgBZVaOtnksWVh0vQiTzEWx5JO0/4O 7dXlY9wX9aIMiNBkkmVnCkY3r+TkdRn1Lz2OUUvo5//aj8xXBbwKJwyVtPVAT0O/JTQL mpDFfXiH73Hu/Gjfpm5+6oiITadkCg2wT5qEK24Sy7WRFCeW4wZZKJtw+5tZms61SCUF wkTNH0rQdrKda2ml92492Kks0oLxwDEwik5iVBpQ8BSIZYMNKOpJvtN3dl/IiIALfyFQ x0jA== X-Gm-Message-State: ABy/qLbl/O6s+bOICRp5PC2DqznIXy7YzzaWyQmtuakqAqLPcupE/MLy Rw5FeB9cd+3ukI/xFSck1lU= X-Google-Smtp-Source: APBJJlFZdqm8ThkZjnxYMjuP9AQePzZIWIx05VnLAa6gfXvg+ng5M8OiDbs25MV4A2nQGDG1EVAhoQ== X-Received: by 2002:a05:6a00:88b:b0:681:415d:ba2c with SMTP id q11-20020a056a00088b00b00681415dba2cmr7424986pfj.31.1690469014066; Thu, 27 Jul 2023 07:43:34 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id v21-20020aa78095000000b00677af363905sm1574243pff.59.2023.07.27.07.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 07:43:33 -0700 (PDT) Message-ID: <86dc9255-3d7b-54fc-1c3c-35373218c5f0@gmail.com> Date: Thu, 27 Jul 2023 08:43:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 0/5] Recognize Zicond extension Content-Language: en-US To: Xiao Zeng , gcc-patches Cc: research_trasio , "kito.cheng" , zhengyu , eri-sw-toolchain References: <20230719101156.21771-1-zengxiao@eswincomputing.com> <2023072716434903717718@eswincomputing.com> From: Jeff Law In-Reply-To: <2023072716434903717718@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/27/23 02:43, Xiao Zeng wrote: > > 2. According to your opinions, I have modified the code, but out of caution > for upstream, I conducted a complete regression tests on patch V2, which took > some time. I was unable to reply to emails and upload patch V2 in a timely manner. Sorry to have wasted your time -- zicond/xventanacondops has lingered for quite a while and I had a bit of free time yesterday. I felt it was most useful to try and move this stuff forward. > > 3 After you and other maintainers made minor modifications to my patch[1/5] > and patch[2/5], it has been merged into the master, so I will no longer upload patch V2. Agreed. > > 4 patch[1/5] and patch[2/5], which have been merged into the master, have only > completed basic support for Zicond, and further optimization work needs to be > completed. These further optimization reactions are reflected in my patch[3/5] > patch[4/5] and patch[5/5]. Agreed. > > 5 As you mentioned in your previous email https://gcc.gnu.org/pipermail/gcc-patches/2023-July/625427.html > "eswincomputing and ventana can both reduce our divergence from the trunk > and work together on the rest of the bits...". I will reorganize patch[3/5] patch[4/5] > and patch[5/5], provide more detailed explanations, and submit them as an alternative > solution for further optimization of Zicond. > > Does that work for you? I'm going to look at 3/5 today pretty closely. Exposing zicond to movcc is something we had implemented inside Ventana and I want to compare/contrast your work with ours. What I like about yours is it keeps all the logic in riscv.cc rather than scattering it across riscv.cc and riscv.md. What I like about the internal Ventana bits is its ability to support arbitrary comparisons by utilizing sCC if the original is not an eq/ne comparison. Ideally we'll be able to get the best of both. Jeff