public inbox for
 help / color / mirror / Atom feed
From: Nathan Sidwell <>
To: James Abbatiello <>,
Subject: Re: [PATCH] PR c++/77306 - Unable to specify visibility for explicit template instantiations
Date: Tue, 30 May 2017 17:50:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 05/21/2017 11:47 PM, James Abbatiello wrote:
> On Sat, Apr 22, 2017 at 4:46 PM, James Abbatiello <> wrote:
>> This is my first time attempting a contribution here so please point
>> out any mistakes.  I've tested this on x86_64-pc-linux-gnu in a VM.
> Hello,
> It has been a few weeks.  Can anybody give me some feedback here or
> tell me if I've done something wrong?

You're changing the behaviour for all structures -- including the C FE. 
That seems wrong.

Also, AFAICT, youre not changing the visibility for members of the 
struct.  Which also seems incorrect.


Nathan Sidwell

  reply	other threads:[~2017-05-30 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22 23:32 James Abbatiello
2017-05-22  4:37 ` James Abbatiello
2017-05-30 17:50   ` Nathan Sidwell [this message]
2017-05-24 19:28 ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).