public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@acm.org>
To: James Abbatiello <abbeyj@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR c++/77306 - Unable to specify visibility for explicit template instantiations
Date: Tue, 30 May 2017 17:50:00 -0000	[thread overview]
Message-ID: <86f2b739-c99a-c79f-2813-9a67ab1d5906@acm.org> (raw)
In-Reply-To: <CANhYFp0T0=TmBOsZMi+XFLp7V_1XnZssiSOn-aWV2J78Nv9_wg@mail.gmail.com>

On 05/21/2017 11:47 PM, James Abbatiello wrote:
> On Sat, Apr 22, 2017 at 4:46 PM, James Abbatiello <abbeyj@gmail.com> wrote:
>> This is my first time attempting a contribution here so please point
>> out any mistakes.  I've tested this on x86_64-pc-linux-gnu in a VM.
> 
> Hello,
> 
> It has been a few weeks.  Can anybody give me some feedback here or
> tell me if I've done something wrong?
> https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00975.html


You're changing the behaviour for all structures -- including the C FE. 
That seems wrong.

Also, AFAICT, youre not changing the visibility for members of the 
struct.  Which also seems incorrect.

nathan


-- 
Nathan Sidwell

  reply	other threads:[~2017-05-30 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22 23:32 James Abbatiello
2017-05-22  4:37 ` James Abbatiello
2017-05-30 17:50   ` Nathan Sidwell [this message]
2017-05-24 19:28 ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86f2b739-c99a-c79f-2813-9a67ab1d5906@acm.org \
    --to=nathan@acm.org \
    --cc=abbeyj@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).