From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Improve std::rotate usages
Date: Tue, 12 Jun 2018 20:39:00 -0000 [thread overview]
Message-ID: <86f8831d-6a6c-5378-9548-c1d9dea994ac@gmail.com> (raw)
In-Reply-To: <5158daaa-ecc0-fc7b-dd1b-a1c7334ed1ae@gmail.com>
I'm struggling having a validation for this patch.
As it is a trivial one and to not bother you I plan to commit it
tomorrow if not told otherwise.
François
On 08/06/2018 07:54, François Dumont wrote:
> Gentle reminder.
>
> On 27/05/2018 19:25, François Dumont wrote:
>> Still no chance to review it ?
>>
>> I'd like this one to go in before submitting other algo related patches.
>>
>> Â Â Â * include/bits/stl_algo.h
>> Â Â Â (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag))
>> Â Â Â (__rotate(_Ite, _Ite, _Ite, bidirectional_iterator_tag))
>> Â Â Â (__rotate(_Ite, _Ite, _Ite, random_access_iterator_tag)): Move
>> code duplication...
>> Â Â Â (rotate(_Ite, _Ite, _Ite)): ...here.
>> Â Â Â (__stable_partition_adaptive(_FIt, _FIt, _Pred, _Dist, _Pointer,
>> _Dist)):
>> Â Â Â Simplify rotate call.
>> Â Â Â (__rotate_adaptive(_BIt1, _BIt1, _BIt1, _Dist, _Dist, _Bit2,
>> _Dist)):
>> Â Â Â Likewise.
>> Â Â Â (__merge_without_buffer(_BIt, _BIt, _BIt, _Dist, _Dist, _Comp)):
>> Â Â Â Likewise.
>>
>> François
>>
>> On 14/05/2018 22:14, François Dumont wrote:
>>> Any feedback regarding this patch ?
>>>
>>>
>>> On 02/05/2018 07:26, François Dumont wrote:
>>>> Hi
>>>>
>>>> Â Â Â std::rotate already returns the expected iterator so there is
>>>> no need for calls to std::advance/std::distance.
>>>>
>>>> Tested under Linux x86_64, ok to commit ?
>>>>
>>>> François
>>>>
>>>
>>
>
next prev parent reply other threads:[~2018-06-12 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 5:26 François Dumont
2018-05-14 20:15 ` François Dumont
2018-05-27 22:01 ` François Dumont
2018-06-08 5:55 ` François Dumont
2018-06-12 20:39 ` François Dumont [this message]
2018-06-12 23:13 ` Jonathan Wakely
2018-07-24 10:23 ` François Dumont
2018-08-07 14:12 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86f8831d-6a6c-5378-9548-c1d9dea994ac@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).