From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92458 invoked by alias); 12 Jun 2018 20:39:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92436 invoked by uid 89); 12 Jun 2018 20:39:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=reminder, struggling, HContent-Transfer-Encoding:8bit X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wr0-f176.google.com Received: from mail-wr0-f176.google.com (HELO mail-wr0-f176.google.com) (209.85.128.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jun 2018 20:39:19 +0000 Received: by mail-wr0-f176.google.com with SMTP id d2-v6so358971wrm.10; Tue, 12 Jun 2018 13:39:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mcvwJ4i+baXvuESSENPbcEyXsYBha3ZC7b0T5JSUhl8=; b=iYpudic81vLyjDcnJY6eQBM19Yn3v3Ci9J8uQvBjRwi2f3DnSpNHpoZJtnWT5+0aEl e2oRI755oOlpE6Sgv96v23VGsvvFqYHSw2Cn4BA3boNmsFglzZGpW90vCa6RoNs+XgN9 fQG0ojfnZd/A11zfYC+fxRafQe1PrR+L9ogdizfSURjp9ReGgGVOpA9wOLfu8TcYQtl+ ZKgkby8isQy2V9uiycZ2XpCQxmSsY3m4CSMx4I4i9w4yAIYAF+WVuYGix3ZB/UYgLGCe NlRhABS+wTDs19yIEZyCZYS0v8r4KIvz44zdX2NOMMwUcoISQvgPXVwjSHdPoWRC2hcx 5voQ== X-Gm-Message-State: APt69E2HbSM/rROGDP7U42MAlJtXBTbxmhLdaGfU2/6fabIeAytSHilP 00QkGgsdd6zv5EFEZd7QEKTcgw== X-Google-Smtp-Source: ADUXVKJQGg+kOr4SoD5MdeNtaw7nE1AnYzmjnMi4eRgOcIFKIoEBq58zqWI+jyMXtMXmpVjrfKu3sg== X-Received: by 2002:adf:9561:: with SMTP id 88-v6mr1698728wrs.223.1528835957674; Tue, 12 Jun 2018 13:39:17 -0700 (PDT) Received: from [192.168.0.37] (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by smtp.googlemail.com with ESMTPSA id k82-v6sm2216001wmg.10.2018.06.12.13.39.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jun 2018 13:39:16 -0700 (PDT) Subject: Re: Improve std::rotate usages From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= To: "libstdc++@gcc.gnu.org" , gcc-patches References: <60f982e6-0fd3-79e6-6b63-f956e051538a@gmail.com> <408a1e34-8441-adf4-b48a-bf53934f62ef@gmail.com> <09ac2f4a-083c-8345-e6d8-0a13afae0f9e@gmail.com> <5158daaa-ecc0-fc7b-dd1b-a1c7334ed1ae@gmail.com> Message-ID: <86f8831d-6a6c-5378-9548-c1d9dea994ac@gmail.com> Date: Tue, 12 Jun 2018 20:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <5158daaa-ecc0-fc7b-dd1b-a1c7334ed1ae@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-06/txt/msg00705.txt.bz2 I'm struggling having a validation for this patch. As it is a trivial one and to not bother you I plan to commit it tomorrow if not told otherwise. François On 08/06/2018 07:54, François Dumont wrote: > Gentle reminder. > > On 27/05/2018 19:25, François Dumont wrote: >> Still no chance to review it ? >> >> I'd like this one to go in before submitting other algo related patches. >> >>     * include/bits/stl_algo.h >>     (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag)) >>     (__rotate(_Ite, _Ite, _Ite, bidirectional_iterator_tag)) >>     (__rotate(_Ite, _Ite, _Ite, random_access_iterator_tag)): Move >> code duplication... >>     (rotate(_Ite, _Ite, _Ite)): ...here. >>     (__stable_partition_adaptive(_FIt, _FIt, _Pred, _Dist, _Pointer, >> _Dist)): >>     Simplify rotate call. >>     (__rotate_adaptive(_BIt1, _BIt1, _BIt1, _Dist, _Dist, _Bit2, >> _Dist)): >>     Likewise. >>     (__merge_without_buffer(_BIt, _BIt, _BIt, _Dist, _Dist, _Comp)): >>     Likewise. >> >> François >> >> On 14/05/2018 22:14, François Dumont wrote: >>> Any feedback regarding this patch ? >>> >>> >>> On 02/05/2018 07:26, François Dumont wrote: >>>> Hi >>>> >>>>     std::rotate already returns the expected iterator so there is >>>> no need for calls to std::advance/std::distance. >>>> >>>> Tested under Linux x86_64, ok to commit ? >>>> >>>> François >>>> >>> >> >