From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32233 invoked by alias); 23 Apr 2015 14:30:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32159 invoked by uid 89); 23 Apr 2015 14:30:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Apr 2015 14:30:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3NEUbGd001831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Apr 2015 10:30:37 -0400 Received: from localhost (ovpn-116-87.ams2.redhat.com [10.36.116.87]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3NEUZQ5016190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 23 Apr 2015 10:30:37 -0400 Received: by localhost (Postfix, from userid 1001) id D649B1A05AA; Thu, 23 Apr 2015 16:30:34 +0200 (CEST) From: Dodji Seketeli To: Marek Polacek Cc: GCC Patches , Joseph Myers , Manuel =?utf-8?B?TMOzcGV6LUliw6HDsWV6?= Subject: Re: [PATCH] Quiet down -Wlogical-op a bit (PR c/61534) References: <20150422135631.GG28950@redhat.com> X-URL: http://www.redhat.com Date: Thu, 23 Apr 2015 14:30:00 -0000 In-Reply-To: <20150422135631.GG28950@redhat.com> (Marek Polacek's message of "Wed, 22 Apr 2015 15:56:31 +0200") Message-ID: <86h9s6udbp.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-04/txt/msg01416.txt.bz2 Hi! Marek Polacek writes: > This patch stifles -Wlogical-op a bit: don't warn if either operand > comes from a macro expansion. As the comment says, it doesn't fix the > bug completely, but it's a simple improvement. I cannot approve this patch, but for what it's worth, I like it and would vote for it to go in. > I did this by introducing a new macro. Fair enough. [...] > Bootstrapped/regtested on x86_64-linux, ok for trunk? [+1] from me. Thanks! -- Dodji