From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [IPv6:2001:67c:2050:0:465::103]) by sourceware.org (Postfix) with ESMTPS id 8EEA23857352; Wed, 16 Aug 2023 13:51:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EEA23857352 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4RQqL24Rwhz9sdf; Wed, 16 Aug 2023 15:51:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1692193882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Eag+SKEj3YI6hXLcJgiFkyVRxhCkTR5++6WFabAXoE4=; b=PIxt1KpqHpytiBQtPix9tV7/6AdmMyB8twegmYsukGHFHoPApCKPYrosAYajTP1/2nZNVM aZhth5mhbVNavVmuGm4yxZgcawp+In9oLPhsKRvsGqGoiwn8rWnbf/LoY3gHSj8MRzC+Ax npF9OGaQitYkUGYeBU0MFLSy0LCHs88sUo5FNj5sy975U6qS4Ot1u4+zM0avviCd0hkGv2 ympXQaE3fEeW8D1hyIXRl3Ge8+zfchb3NgmxJXuKoWECmfNq0Pppk7h29ud5avT0Ks02R+ uPYc8uu/NfbhWvH/xXIWZSNEJvIBGbyr94Y3EpNZkFN5pFi5m9edC+sBsici0Q== References: From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Jonathan Wakely Cc: "Paul M. Bendixen" , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++ Add cstdarg to freestanding Date: Wed, 16 Aug 2023 15:27:20 +0200 In-reply-to: Message-ID: <86leeb9jtz.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jonathan Wakely writes: > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ > wrote: >> >> P1642 includes the header cstdarg to the freestanding implementation. >> This was probably left out by accident, this patch puts it in. >> Since this is one of the headers that go in whole cloth, there should be= no >> further actions needed. > > Thanks for the patch. I agree that should be freestanding, > but I think and were also missed from the > change. Arsen? Indeed, we should include all three, and according to [compliance], there's a couple more headers that we should provide (cwchar, cstring, cerrno, and cmath, but these are probably significantly more involved, so we can handle them separately). As guessed, the omission was not intentional. If you could, add those two to the patch as well, edit Makefile.am and regenerate using automake 1.15.1, and see https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. Thank you! Have a lovely day :-) [compliance]: https://eel.is/c++draft/compliance > Also, the patch should change include/Makefile.am as well (the .in > file is autogenerated from that one). > > >> This might be related to PR106953, but since that one touches the partial >> headers I'm not sure The headers mentioned in this PR are provided in freestanding, partially, in 13 already, indeed. >> /Paul M. Bendixen >> >> -- >> =E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92/=E2=80=A2 = =E2=80=A2 =E2=88=92/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=88=92 =E2= =80=A2 =E2=80=A2 =E2=80=A2/=E2=80=A2/=E2=88=92 =E2=80=A2/=E2=88=92 =E2=80= =A2 =E2=80=A2/=E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80=A2 =E2=80=A2 =E2=88=92/= =E2=80=A2/=E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2=E2=88= =92 >> =E2=80=A2/=E2=88=92 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92/=E2=80=A2 = =E2=88=92/=E2=80=A2 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2= =80=A2 =E2=88=92 =E2=80=A2 =E2=88=92 =E2=80=A2 =E2=88=92/=E2=88=92 =E2=80= =A2 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=88=92/=E2=88=92 =E2=88=92// =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZNzUWF8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosST0DwBANQYTXw2/rSptSsfRcxrP/7ElS1m/1Rosf1m 752RjvJPAP4zoEHfX7JYP4Q3f5j2twWI55xOO/b1BTHTow9LoOgBBQ== =QmDx -----END PGP SIGNATURE----- --=-=-=--