From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by sourceware.org (Postfix) with ESMTPS id 99B3F3858280 for ; Sat, 11 Mar 2023 20:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99B3F3858280 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4PYvYF6Wkbz9sWC; Sat, 11 Mar 2023 21:25:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1678566305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rNQ2edEORTKtjk+SajSUB2xEvolpa2uui3N33PLP2YY=; b=IKbctYgelVjcFT0slfqL49Dmw2LW0thnElhe0X/Ava1qyu5aUNp5k5oo3jMoXUbym4IlZd lXWTNrIwaKXxEodU4H2k6M55e1A5FUECTMqshLh1EN/0eF3IntgT1/jEPXKTL19II0tZpp twcTbCcwF0mBQy20kDm495pwh8mgyCese5uwW1RxCoXSNJ0qWzu8t0fTTbBVv7LliSetFz kjeJVOqAeYnKv8OxOempohd71LUb3Evt0ROXKO2j3uTRwM23o/PqsIkhm1L3mAZMoydJqd R/Q9oYdcgUTTWyaHiWF/y49W2OF1LuVZXia+8hVkLLQe33MkNljtwtcQSlJZ+g== References: <20230223102714.3606058-1-arsen@aarsen.me> <20230223102714.3606058-2-arsen@aarsen.me> <9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com> <86sfed63l6.fsf@aarsen.me> <1db33a21-4645-1c63-faf2-4048be07c323@siemens.com> <86356b1nnh.fsf@aarsen.me> <4d6acae7-f275-74a8-a960-67c8a1deb482@pfeifer.com> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Gerald Pfeifer Cc: Sandra Loosemore , gcc-patches@gcc.gnu.org, Joseph Myers Subject: Re: [PATCH v2 1/5] docs: Create Indices appendix Date: Sat, 11 Mar 2023 21:22:28 +0100 In-reply-to: <4d6acae7-f275-74a8-a960-67c8a1deb482@pfeifer.com> Message-ID: <86sfebvxwg.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Gerald Pfeifer writes: > On Sat, 11 Mar 2023, Arsen Arsenovi=C4=87 wrote: >> OK, changed up a bit, what do you think of this: > >> maintainer-scripts/ChangeLog: >> >> * update_web_docs_git: Set CONTENTS_OUTPUT_LOCATION=3Dinline in >> order to put @shortcontents above contents. See >> 9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com on >> gcc-patches. > > In the ChangeLog we only describe *what* has change, so the first half of= =20 > the first sentence. > > The rest then goes in between the first line of the Git commit message > (=3D the subject of your mail) and the ChangeLog entries. Ah, OK. I decided to put it there, too (and repeat it twice), since the ChangeLog crafting script doesn't include the commit message for context. I've dropped that now. > >> --- a/gcc/configure >> +++ b/gcc/configure > > We usually don't post diffs for generated files. Not a biggie, I figured = I=20 > mention it since it makes reviewing easier and patches shorter, and thus= =20 > tends to increase the chance reviewers short on time jump in. :-) Ah, d'oh. I forgot to filter that out. Apologies. > >> --- a/maintainer-scripts/update_web_docs_git >> +++ b/maintainer-scripts/update_web_docs_git >> @@ -169,7 +169,7 @@ for file in $MANUALS; do >> if [ "$file" =3D "gnat_ugn" ]; then >> includes=3D"$includes -I gcc/gcc/ada -I gcc/gcc/ada/doc/gnat_ugn" >> fi >> - makeinfo --html --css-ref $CSS $includes -o ${file} ${filename} >> + makeinfo --html -c CONTENTS_OUTPUT_LOCATION=3Dinline --css-ref $CSS= $includes -o ${file} ${filename} > > Sandra deferred to me on this one, so explicitly: Ack, thank you. :-) > > Note, update_web_docs_git runs once a day, at 0:50 GMT, see=20 > gcc/maintainer-scripts/crontab, and needs to be updated on the gcc.gnu.or= g=20 > system. I am happy to do that for you, just drop me a note when the commit > is in. Sure thing, thanks! > Gerald =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZAzjn18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTerQA/iknpwZ9kuU3rAJnJSIpvWDwTFWR3mZZRykG DCnHquQ5AQDlqDc91MCF2Qjq43XTADFi7mFWKMxEkYzmtaNKiKxdDQ== =AGLO -----END PGP SIGNATURE----- --=-=-=--