Re: [PATCH 0/2] Replace intl/ with out-of-tree GNU gettext

["Arsen Arsenović" <arsen@aarsen.me>]

[-- Attachment #1: Type: text/plain, Size: 2649 bytes --]


Bruno Haible <bruno@clisp.org> writes:

> Arsen Arsenović wrote:
>> -+The in-tree configuration requires GNU gettext v0.22.
>
> Can you change this to "... requires GNU gettext version 0.22 or newer.", please?
> I wouldn't like to give the impression that a particular release (0.22) is the
> only one that works.
> Also, some people may understand 'v' as meaning "version", but some may not.

Certainly, good idea.  Thanks for the notes.

>> +Forces the gettext tree to be configured to build and use a new static
>> +libintl, overriding the system libintl.
>
> This sounds like it has no effects on the GCC tree, only on the gettext
> tree. Surely that's not the intention?

Hmm, well, it has no primary effect on the gettext tree, only the
secondary effect of 'if gettext is configured with this flag, then other
parts of the source tree use included over system gettext'.


Do you like the following?

@@ -486,7 +486,7 @@ found in a subdirectory of your GCC sources
 will be built together with GCC, unless present in the system (either in
 libc or as a stand-alone library).
 
-The in-tree configuration requires GNU gettext v0.22.
+The in-tree configuration requires GNU gettext version 0.22 or later.
 
 @end table
 
@@ -2229,7 +2229,8 @@ Specifies the type of library to search
 Only available if @file{gettext} is present in the source tree.
 
 Forces the gettext tree to be configured to build and use a new static
-libintl, overriding the system libintl.
+libintl, overriding the system libintl.  Results in GCC being built
+against the newly built libintl rather than the system libintl.
 
 @item --with-catgets
 If NLS is enabled, and if the host lacks @code{gettext} but has the

I'm open to better wording in the hunk 2 paragraph.

>>    --with-libiconv-prefix[=DIR]  search for libiconv in DIR/include and DIR/lib
>>    --without-libiconv-prefix     don't search for libiconv in includedir and libdir
>>    --with-libiconv-type=TYPE     type of library to search for (auto/static/shared)
>> +  --with-libintl-prefix[=DIR]  search for libintl in DIR/include and DIR/lib
>> +  --without-libintl-prefix     don't search for libintl in includedir and libdir
>> +  --with-libintl-type=TYPE     type of library to search for (auto/static/shared)
>
> It looks like an additional space in the middle of the last three lines would
> provide a better alignment for the 'configure --help' output.

Hmm, I thought that AS_HELP_STRING handles that..  These flags are
(AFAIK) from inside AM_GNU_GETTEXT, so I'm unsure on how to change this
formatting properly.
-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]