From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-477649-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 66453 invoked by alias); 14 May 2018 14:19:39 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 66441 invoked by uid 89); 14 May 2018 14:19:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.2 spammy=H*UA:Android
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 May 2018 14:19:36 +0000
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 24D9BAE03;	Mon, 14 May 2018 14:19:33 +0000 (UTC)
Date: Mon, 14 May 2018 14:27:00 -0000
User-Agent: K-9 Mail for Android
In-Reply-To: <CAAgBjMmKfFg=CJfKtB1o_aJAnqAX5Mr2hJPnxxgG7Cwu=erO0g@mail.gmail.com>
References: <CAAgBjM=VeybyghFgEThw55mQRSHy3w_+4Dg__NAtkJOQEF_FMQ@mail.gmail.com> <alpine.LSU.2.20.1805141114240.24704@zhemvz.fhfr.qr> <CAAgBjMmiswzFOcPwFdu+PyhhwggnEwPiZ9oemSqsQPTqNjWMCA@mail.gmail.com> <alpine.LSU.2.20.1805141136340.24704@zhemvz.fhfr.qr> <CAAgBjMmKfFg=CJfKtB1o_aJAnqAX5Mr2hJPnxxgG7Cwu=erO0g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: PR85734
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
CC: gcc Patches <gcc-patches@gcc.gnu.org>,Jan Hubicka <hubicka@ucw.cz>
From: Richard Biener <rguenther@suse.de>
Message-ID: <87164C48-2B4E-41D7-83B7-5B1EA2D91D9B@suse.de>
X-SW-Source: 2018-05/txt/msg00622.txt.bz2

On May 14, 2018 2:30:27 PM GMT+02:00, Prathamesh Kulkarni <prathamesh.kulka=
rni@linaro.org> wrote:
>On 14 May 2018 at 15:06, Richard Biener <rguenther@suse.de> wrote:
>> On Mon, 14 May 2018, Prathamesh Kulkarni wrote:
>>
>>> On 14 May 2018 at 14:46, Richard Biener <rguenther@suse.de> wrote:
>>> > On Mon, 14 May 2018, Prathamesh Kulkarni wrote:
>>> >
>>> >> Hi,
>>> >> The attached patch tries to fix PR85734, by gating on
>>> >> !function_always_visible_to_compiler_p.
>>> >> Bootstrap+test in progress on x86_64.
>>> >> OK to commit if passes ?
>>> >
>>> > This looks redundant - suggest_attribute does that very same check
>>> > but warn_function_malloc passes it 'false' as known_finite
>>> > (warn_function_noreturn passes it true for example).
>>> Indeed, thanks for pointing it out.
>>> >
>>> > So I suggest to simply pass true as that arg.
>>> Is the attached version OK to commit after bootstrap+test ?
>>
>> Yes.
>Also on a related bug PR85562, should we change the wording of
>suggest_attribute for malloc
>to omit the text "if it is known to return normally" ?

Yes.=20

Richard.=20

>Thanks,
>Prathamesh
>> Richard.
>>
>>> Thanks,
>>> Prathamesh
>>> >
>>> > Richard
>>> >
>>> >> Thanks,
>>> >> Prathamesh
>>> >>
>>> >
>>> > --
>>> > Richard Biener <rguenther@suse.de>
>>> > SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham
>Norton, HRB 21284 (AG Nuernberg)
>>>
>>
>> --
>> Richard Biener <rguenther@suse.de>
>> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham
>Norton, HRB 21284 (AG Nuernberg)