* [Committed] RISC-V: Suppress warning
@ 2024-01-20 0:27 Juzhe-Zhong
2024-01-20 0:52 ` Jeff Law
0 siblings, 1 reply; 5+ messages in thread
From: Juzhe-Zhong @ 2024-01-20 0:27 UTC (permalink / raw)
To: gcc-patches; +Cc: pan2.li, schwab, Juzhe-Zhong
../../gcc/config/riscv/riscv.cc: In function 'void riscv_init_cumulative_args(CUMULATIVE_ARGS*, tree, rtx, tree, int)':
../../gcc/config/riscv/riscv.cc:4879:34: error: unused parameter 'fndecl' [-Werror=unused-parameter]
4879 | tree fndecl,
| ~~~~~^~~~~~
../../gcc/config/riscv/riscv.cc: In function 'bool riscv_vector_mode_supported_any_target_p(machine_mode)':
../../gcc/config/riscv/riscv.cc:10537:56: error: unused parameter 'mode' [-Werror=unused-parameter]
10537 | riscv_vector_mode_supported_any_target_p (machine_mode mode)
| ~~~~~~~~~~~~~^~~~
cc1plus: all warnings being treated as errors
make[3]: *** [Makefile:2559: riscv.o] Error 1
Suppress these warnings.
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_init_cumulative_args): Suppress warning.
(riscv_vector_mode_supported_any_target_p): Ditto.
---
gcc/config/riscv/riscv.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index dd6e68a08c2..1f9546f4d3e 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -4876,7 +4876,7 @@ void
riscv_init_cumulative_args (CUMULATIVE_ARGS *cum,
tree fntype ATTRIBUTE_UNUSED,
rtx libname ATTRIBUTE_UNUSED,
- tree fndecl,
+ tree fndecl ATTRIBUTE_UNUSED,
int caller ATTRIBUTE_UNUSED)
{
memset (cum, 0, sizeof (*cum));
@@ -10534,7 +10534,7 @@ extract_base_offset_in_addr (rtx mem, rtx *base, rtx *offset)
/* Implements target hook vector_mode_supported_any_target_p. */
static bool
-riscv_vector_mode_supported_any_target_p (machine_mode mode)
+riscv_vector_mode_supported_any_target_p (machine_mode)
{
if (TARGET_XTHEADVECTOR)
return false;
--
2.36.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Committed] RISC-V: Suppress warning
2024-01-20 0:27 [Committed] RISC-V: Suppress warning Juzhe-Zhong
@ 2024-01-20 0:52 ` Jeff Law
2024-01-20 1:18 ` 钟居哲
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Law @ 2024-01-20 0:52 UTC (permalink / raw)
To: Juzhe-Zhong, gcc-patches; +Cc: pan2.li, schwab
On 1/19/24 17:27, Juzhe-Zhong wrote:
> ../../gcc/config/riscv/riscv.cc: In function 'void riscv_init_cumulative_args(CUMULATIVE_ARGS*, tree, rtx, tree, int)':
> ../../gcc/config/riscv/riscv.cc:4879:34: error: unused parameter 'fndecl' [-Werror=unused-parameter]
> 4879 | tree fndecl,
> | ~~~~~^~~~~~
> ../../gcc/config/riscv/riscv.cc: In function 'bool riscv_vector_mode_supported_any_target_p(machine_mode)':
> ../../gcc/config/riscv/riscv.cc:10537:56: error: unused parameter 'mode' [-Werror=unused-parameter]
> 10537 | riscv_vector_mode_supported_any_target_p (machine_mode mode)
> | ~~~~~~~~~~~~~^~~~
> cc1plus: all warnings being treated as errors
> make[3]: *** [Makefile:2559: riscv.o] Error 1
>
> Suppress these warnings.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.cc (riscv_init_cumulative_args): Suppress warning.
> (riscv_vector_mode_supported_any_target_p): Ditto.
There's actually more cleanup to do in there ;-) One of the arguments
currently marked as unused is actually used. And the better way to
handle unused arguments is to just drop their name (like you did with
riscv_vector_mode_supported_any_target_p).
I'm actually in the process of bootstrapping and regression testing the
additional fixes to riscv_init_cumulative_args.
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [Committed] RISC-V: Suppress warning
2024-01-20 0:52 ` Jeff Law
@ 2024-01-20 1:18 ` 钟居哲
2024-01-21 22:51 ` Jeff Law
0 siblings, 1 reply; 5+ messages in thread
From: 钟居哲 @ 2024-01-20 1:18 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: pan2.li, Andreas Schwab
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
OK. I saw the other arguments there:
tree fntype ATTRIBUTE_UNUSED,
rtx libname ATTRIBUTE_UNUSED,
So I leverage these and add ATTRIBUTE_UNUSED to 'fndecl'
Maybe it's better remove all arguments for riscv_init_cumulative_args which are unused as you suggested.
juzhe.zhong@rivai.ai
From: Jeff Law
Date: 2024-01-20 08:52
To: Juzhe-Zhong; gcc-patches
CC: pan2.li; schwab
Subject: Re: [Committed] RISC-V: Suppress warning
On 1/19/24 17:27, Juzhe-Zhong wrote:
> ../../gcc/config/riscv/riscv.cc: In function 'void riscv_init_cumulative_args(CUMULATIVE_ARGS*, tree, rtx, tree, int)':
> ../../gcc/config/riscv/riscv.cc:4879:34: error: unused parameter 'fndecl' [-Werror=unused-parameter]
> 4879 | tree fndecl,
> | ~~~~~^~~~~~
> ../../gcc/config/riscv/riscv.cc: In function 'bool riscv_vector_mode_supported_any_target_p(machine_mode)':
> ../../gcc/config/riscv/riscv.cc:10537:56: error: unused parameter 'mode' [-Werror=unused-parameter]
> 10537 | riscv_vector_mode_supported_any_target_p (machine_mode mode)
> | ~~~~~~~~~~~~~^~~~
> cc1plus: all warnings being treated as errors
> make[3]: *** [Makefile:2559: riscv.o] Error 1
>
> Suppress these warnings.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.cc (riscv_init_cumulative_args): Suppress warning.
> (riscv_vector_mode_supported_any_target_p): Ditto.
There's actually more cleanup to do in there ;-) One of the arguments
currently marked as unused is actually used. And the better way to
handle unused arguments is to just drop their name (like you did with
riscv_vector_mode_supported_any_target_p).
I'm actually in the process of bootstrapping and regression testing the
additional fixes to riscv_init_cumulative_args.
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Committed] RISC-V: Suppress warning
2024-01-20 1:18 ` 钟居哲
@ 2024-01-21 22:51 ` Jeff Law
2024-01-21 23:29 ` Andreas Schwab
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Law @ 2024-01-21 22:51 UTC (permalink / raw)
To: 钟居哲, gcc-patches; +Cc: pan2.li, Andreas Schwab
On 1/19/24 18:18, 钟居哲 wrote:
> OK. I saw the other arguments there:
>
> tree fntype ATTRIBUTE_UNUSED,
> rtx libname ATTRIBUTE_UNUSED,
>
> So I leverage these and add ATTRIBUTE_UNUSED to 'fndecl'
>
> Maybe it's better remove all arguments for riscv_init_cumulative_args
> which are unused as you suggested.
Yea. The biggest problem with ATTRIBUTE_UNUSED is that it's a "may be
unused" and thus if the code changes it's sometimes left on an parameter
incorrectly. C++ allows us to specify a "is definitely unused" concept
by dropping the parameter's name, but leaving its type.
I just pushed the obvious patch to fixup that function signature. It
would be a nice easy task for someone to go through all of riscv*.cc and
clean those up after gcc-14 branches.
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Committed] RISC-V: Suppress warning
2024-01-21 22:51 ` Jeff Law
@ 2024-01-21 23:29 ` Andreas Schwab
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2024-01-21 23:29 UTC (permalink / raw)
To: Jeff Law; +Cc: 钟居哲, gcc-patches, pan2.li
On Jan 21 2024, Jeff Law wrote:
> Yea. The biggest problem with ATTRIBUTE_UNUSED is that it's a "may be
> unused" and thus if the code changes it's sometimes left on an parameter
> incorrectly. C++ allows us to specify a "is definitely unused" concept by
> dropping the parameter's name, but leaving its type.
It's problematic if the parameter is only used conditionally on a macro
definition (which is less common with target hooks now being function
calls).
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-21 23:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-20 0:27 [Committed] RISC-V: Suppress warning Juzhe-Zhong
2024-01-20 0:52 ` Jeff Law
2024-01-20 1:18 ` 钟居哲
2024-01-21 22:51 ` Jeff Law
2024-01-21 23:29 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).