From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id B2E873858003 for ; Tue, 5 Dec 2023 09:31:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2E873858003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2E873858003 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701768714; cv=none; b=ROOLZbHW5Vi25ox1Qk+UB8qhJal4ARP01i9FG/Gdd19odHyrEXlHDw8rWWvr5y+YMaCZqZYiN3Bi56j0cZqCuBPRVRsHyFNGN+2IW/Sbfn/LWMgTO4bqkbgMNmj82Ccm7c/YMNjR90SSBeimblqtYpiEfSYl7wHYaZ/BMYBbnG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701768714; c=relaxed/simple; bh=VPe1TsNpMQOB3xKF0OT8aIWPG4VDr9bq9atqQGciDKQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=e7c31RTL9eJG9SfW2bQOyM7/i4To22dQ+CLC0R6xFoqnyf0osWgJAvDPIPe13xwy43bTvj4DeEerTwJPLodU/zPR/u5f/AA4aPoRqJ1t+62jmOr0mANM6W9YDrW2Wfd+BXLHJYW4XaY8nB0jBkydkTD4PPDyeBjcsnhlyAME9nM= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: wCaGcf6YT+S0al78ePV7Rw== X-CSE-MsgGUID: Cwb4BV8RQvSGgtVA60hBZQ== X-IronPort-AV: E=Sophos;i="6.04,251,1695715200"; d="scan'208,223";a="27691283" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 05 Dec 2023 01:31:50 -0800 IronPort-SDR: 00Qu2qdzU+Ek3jlBDAaPfq0bYM7JeekVBWd/IuYXnWm5gBGiJWU12h2UrjiQjCJH+c7yQYk940 hIUXKwFJnPkmsiNCutfYt9wcGMiDgTvCnjRSS9Y5oumji4TceUQiNHfIDev9m9H06QHGvwA0lH NQzfQp5Xae2/BYQs+O9HARg70MxjpicAbcfB7DeHSfx3Whlevw3e3JgkfDxyp7XJU+leAw9/VB ow/rvfU1OiE3GwropHm4fMCkk7hQN7++ViWgzWEZUK1dww4A93wpAJ0rJQUc77zYYOhz/szJHt EVY= From: Thomas Schwinge To: Jeff Law , Florian Weimer , Joseph Myers , Subject: [v2] c: Turn -Wimplicit-function-declaration into a permerror: Fix 'gcc.dg/gnu23-builtins-no-dfp-1.c' (was: [committed] Fix gnu23-builtins-no-dfp) In-Reply-To: <5f1eb4d5-d168-4ce9-8eb8-39644206fff3@gmail.com> References: <87fs0luded.fsf@euler.schwinge.homeip.net> <3dbc2b93-78fb-47b3-95a6-1efc76d78077@gmail.com> <87cyvn91h4.fsf@mid.deneb.enyo.de> <878r6btqyv.fsf@euler.schwinge.homeip.net> <5f1eb4d5-d168-4ce9-8eb8-39644206fff3@gmail.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Tue, 5 Dec 2023 10:31:43 +0100 Message-ID: <871qc15728.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_LOTSOFHASH,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! On 2023-12-03T13:57:36-0700, Jeff Law wrote: > On 12/3/23 05:23, Thomas Schwinge wrote: >> On 2023-12-03T08:41:59+0100, Florian Weimer wrote: >> >> "c: Turn -Wimplicit-function-declaration into a permerror: Fix 'gcc.dg/g= nu23-builtins-no-dfp-1.c'", >> awaiting review. Rationale: For this test case it's secondary *how* >> "implicit declaration of function" is diagnosed, so I'd test the standar= d >> way, which instead of "warning" now is "error". (But no strong feelings >> either way.) ;-) > Sorry, I missed your fix. No worries. > I like it better then mine. Approved, along > with reverting my bits. Pushed to master branch commit a1adce82c17577aeaaf6b9736ca8a1455d1164cb "c: Turn -Wimplicit-function-declaration into a permerror: Fix 'gcc.dg/gnu2= 3-builtins-no-dfp-1.c'", see attached. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-c-Turn-Wimplicit-function-declaration-into-a-permerr.patch" >From a1adce82c17577aeaaf6b9736ca8a1455d1164cb Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 1 Dec 2023 16:52:06 +0100 Subject: [PATCH] c: Turn -Wimplicit-function-declaration into a permerror: Fix 'gcc.dg/gnu23-builtins-no-dfp-1.c' With recent commit 55e94561e97ed0bce4774aa1c6b5d5d82209a379 "c: Turn -Wimplicit-function-declaration into a permerror", this test case, added in 2019 commit 5b8d9367684f266c30c280b4d3c98830a88c70ab "Prevent all uses of DFP when unsupported (PR c/91985)" started FAILing (for applicable configurations): [-PASS:-]{+FAIL:+} gcc.dg/gnu23-builtins-no-dfp-1.c (test for warnings, line 13) [-PASS:-]{+FAIL:+} gcc.dg/gnu23-builtins-no-dfp-1.c (test for warnings, line 14) [-PASS:-]{+FAIL:+} gcc.dg/gnu23-builtins-no-dfp-1.c (test for warnings, line 15) [-PASS:-]{+FAIL:+} gcc.dg/gnu23-builtins-no-dfp-1.c (test for warnings, line 16) [-PASS:-]{+FAIL:+} gcc.dg/gnu23-builtins-no-dfp-1.c (test for warnings, line 17) [-PASS:-]{+FAIL:+} gcc.dg/gnu23-builtins-no-dfp-1.c (test for warnings, line 18) [-PASS:-]{+FAIL:+} gcc.dg/gnu23-builtins-no-dfp-1.c (test for excess errors) This is due to: [...]/gcc.dg/gnu23-builtins-no-dfp-1.c:13:13: error: implicit declaration of function '__builtin_fabsd32'; did you mean '__builtin_fabsf32'? [-Wimplicit-function-declaration] [...] Specifying '-fpermissive', commit f37744662cbc74efcceb790b99dcd6521c51a578 "[committed] Fix gnu23-builtins-no-dfp" subsequently resolved the FAILs, but patch review concluded that for this test case it's secondary *how* "implicit declaration of function" is diagnosed, so we'd test the standard way, which instead of "warning" now is "error". gcc/testsuite/ * gcc.dg/gnu23-builtins-no-dfp-1.c: Remove '-fpermissive'. 'dg-error "implicit"' instead of 'dg-warning "implicit"'. --- gcc/testsuite/gcc.dg/gnu23-builtins-no-dfp-1.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gcc/testsuite/gcc.dg/gnu23-builtins-no-dfp-1.c b/gcc/testsuite/gcc.dg/gnu23-builtins-no-dfp-1.c index 8fe4efbdd98..7cb200fce6a 100644 --- a/gcc/testsuite/gcc.dg/gnu23-builtins-no-dfp-1.c +++ b/gcc/testsuite/gcc.dg/gnu23-builtins-no-dfp-1.c @@ -1,7 +1,7 @@ /* Test C23 built-in functions: test DFP built-in functions are not available when no DFP support. Bug 91985. */ /* { dg-do compile { target { ! dfp } } } */ -/* { dg-options "-std=gnu23 -fpermissive" } */ +/* { dg-options "-std=gnu23" } */ int fabsd32 (void); int fabsd64 (void); @@ -10,9 +10,9 @@ int nand32 (void); int nand64 (void); int nand128 (void); -__typeof__ (__builtin_fabsd32 (0)) d32; /* { dg-warning "implicit" } */ -__typeof__ (__builtin_fabsd64 (0)) d64; /* { dg-warning "implicit" } */ -__typeof__ (__builtin_fabsd128 (0)) d128; /* { dg-warning "implicit" } */ -__typeof__ (__builtin_nand32 (0)) d32n; /* { dg-warning "implicit" } */ -__typeof__ (__builtin_nand64 (0)) d64n; /* { dg-warning "implicit" } */ -__typeof__ (__builtin_nand128 (0)) d128n; /* { dg-warning "implicit" } */ +__typeof__ (__builtin_fabsd32 (0)) d32; /* { dg-error "implicit" } */ +__typeof__ (__builtin_fabsd64 (0)) d64; /* { dg-error "implicit" } */ +__typeof__ (__builtin_fabsd128 (0)) d128; /* { dg-error "implicit" } */ +__typeof__ (__builtin_nand32 (0)) d32n; /* { dg-error "implicit" } */ +__typeof__ (__builtin_nand64 (0)) d64n; /* { dg-error "implicit" } */ +__typeof__ (__builtin_nand128 (0)) d128n; /* { dg-error "implicit" } */ -- 2.34.1 --=-=-=--