From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: David Faust <david.faust@oracle.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] bpf: neg instruction does not accept an immediate
Date: Tue, 22 Aug 2023 00:07:58 +0200 [thread overview]
Message-ID: <871qfwjbgh.fsf@oracle.com> (raw)
In-Reply-To: <20230821210347.19947-1-david.faust@oracle.com> (David Faust's message of "Mon, 21 Aug 2023 14:03:47 -0700")
> The BPF virtual machine does not support neg nor neg32 instructions with
> an immediate.
>
> The erroneous instructions were removed from binutils:
> https://sourceware.org/pipermail/binutils/2023-August/129135.html
>
> Change the define_insn so that an immediate cannot be accepted.
>
> From testing, a neg-immediate was probably never chosen over a
> mov-immediate anyway.
OK.
Thanks!
>
> Tested on x86_64-linux-gnu host for bpf-unknown-none target.
>
> gcc/
>
> * config/bpf/bpf.md (neg): Second operand must be a register.
> ---
> gcc/config/bpf/bpf.md | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index a64de1095ed..e87d72182bb 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -163,8 +163,8 @@ (define_insn "sub<AM:mode>3"
>
> ;;; Negation
> (define_insn "neg<AM:mode>2"
> - [(set (match_operand:AM 0 "register_operand" "=r,r")
> - (neg:AM (match_operand:AM 1 "reg_or_imm_operand" " 0,I")))]
> + [(set (match_operand:AM 0 "register_operand" "=r")
> + (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
> ""
> "{neg<msuffix>\t%0|%w0 = -%w1}"
> [(set_attr "type" "<mtype>")])
prev parent reply other threads:[~2023-08-21 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 21:03 David Faust
2023-08-21 22:07 ` Jose E. Marchesi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qfwjbgh.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=david.faust@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).