From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 456A73858D33 for ; Mon, 21 Aug 2023 22:08:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 456A73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37LFxVPT009160 for ; Mon, 21 Aug 2023 22:08:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=Wlwo/tu6cuUEE4GcyjVHBXUksYUE0jhMVZHB9YdjOwk=; b=xoGeAaaDM6WG4kW30Op3P3t3OSR1+B5emmd4DFdTpRB4CBceZVy/cIs5LOPvBksoZ7It qL4Yu4mbgIL1fDBcybOcEPwlWmWZX9knYgxu3TV9MeOEEHl4DosDAGiiXkQbXrT1fYD1 rMVfknS2NV+JcK404nkhF91qzS8azQgvKLW7hohW8F2x2vEsrTUDJuG9zSdy9PJMEZGy IanhxEC0EOASILEHHqhAoDnqlyRC2g5WgId9AjkjW9Q9YcpNS4+yIEDXxl6YLRaZyeac 3IOkQ791Cwu7s6Z0RyPzJLBjrbkb3miqYZyLvR3HEO272s72CrfV/6zxvu0XL2P9trjJ Hg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sjm5dv22h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 22:08:06 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37LKDkxD018693 for ; Mon, 21 Aug 2023 22:08:05 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2049.outbound.protection.outlook.com [104.47.56.49]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3sjm64htqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 22:08:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWAFoq8bDLW3Y6tpYNZ5L4O9rnHxI1geqcD+vnRIu7WICCXQxZ8AAwOMc3MdxwUbqcIOe589EDjK+IiWYeV7z/iEXt32+k+MD6HQap9XeNgsHuGq35WlxjJsT2q1mguBoaR/jx00S8yUbZnsVOB5D/A0mNVEyr0arM/J+YHIZXIiuIfGcwIQXKK8hGpvfw2z8qdyoV5C+ezO656JY/POAPE2cN9lBB/oD6sLbDWPnOqLjix04BQ/G5oVqejdhA6jmK9QwEov1lTchoq+vrAP1JKUdI1fi2L/esq1orSNuORH6nCCNe8poaPcX57Fh0xo0pMN3Wx0eNg3szSD5bY4Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wlwo/tu6cuUEE4GcyjVHBXUksYUE0jhMVZHB9YdjOwk=; b=kbB4vvZdHpfbnx7TgWP1I3kiXLE95ihKHyB6kRVtsIuTFkf2CzqUN7IpVmInYbA2vtN7UlrAbihR6xgKCSWbBnP21oIiMHyCg+PuwH0xZuyUglByagjhTbMXInI9UyEGt1xBsTh4NFGIo6SbzquEVu8Fw/C1qtRT+ysa5V8AJWMaEfvcjChXx1Q7g3PxI8PASuJtfqp9MrXYkIPVZ2PxhA6uyvvHjdjJNnaPsTAJsnpaiphW/eGobm396mgBesjt0FZQrpeNm0es/fuqNAA59QCWJvhRgBe+3JVt6DSEMw+x2HgSq4WDCS4JlJ75MS4t3pf/b4ISWYDKEJ7VTgmF3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wlwo/tu6cuUEE4GcyjVHBXUksYUE0jhMVZHB9YdjOwk=; b=mw6/eOn5X7VmrLrjlJrcNfPT2XdogOehTr0C15SHFWe/81FhR+BrN2Hvkmh2nKp2B2kXpekVZoKS62zoO2L6AEdF1bg2t9ZpeLR4a4oUGMAh9NNb3NdCDakZIhbQye9sSHFxiiwg9y13HiJQ9JUormQ4DUqtfW7OUg9Fz8y4QfU= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by CH3PR10MB7931.namprd10.prod.outlook.com (2603:10b6:610:1cf::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 22:08:03 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::fd36:b9b2:19f5:6f74]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::fd36:b9b2:19f5:6f74%5]) with mapi id 15.20.6699.022; Mon, 21 Aug 2023 22:08:03 +0000 From: "Jose E. Marchesi" To: David Faust Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] bpf: neg instruction does not accept an immediate In-Reply-To: <20230821210347.19947-1-david.faust@oracle.com> (David Faust's message of "Mon, 21 Aug 2023 14:03:47 -0700") References: <20230821210347.19947-1-david.faust@oracle.com> Date: Tue, 22 Aug 2023 00:07:58 +0200 Message-ID: <871qfwjbgh.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: FR2P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::19) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|CH3PR10MB7931:EE_ X-MS-Office365-Filtering-Correlation-Id: a001733f-4c77-4d96-24c4-08dba293170d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X+3b/QBW1wUyB/aasgViUeuXR4PVeHEX4ky0KQCpJEYh43fnObvy5/UOyRPMA1qDw9JOB5C+mu5dfTUkqjAvTsNkV2aL5BYySlhKz0pwFgMkDFEVb43sjhpxIr3B1uO6o849zzro60ped1BOB7huibckiwaLArDXkmv8zR0jU31SjQjkfB9YPmo+YKr481El1zypZEBuYGQ2TLtcIUEGUi7p3YHMaYH8tzpE0cKylkAc1txO4GOm6LLRFiquyftWgvw877mXjso6o+uLj4v7cC9dZtvVPq4aMtOpM9+69ecFRQHEHsDWsU3sTVoFcRikJaOLOTLXqGotqnZMLioa8IRP4W7JrJSfiJxBmYfrXRbZQ+F4vPs8pug7lilTpbILqvlyUldvcdqyw34CRI+9eACPmbyg3F2DTyvfh8RQwYguniGZKhedBb+DjQ2cfmN8+KDQBL8WIDvbwjVbrbOupJ0e5WR9OAIooc33KxBLys5XKkcCsS6PDPYO1CdPLhlxKQtp5HeOVTj37MDzNqMPZ44lSG/AmLbQHpOubaI6VR6wA7WIQkuev9tF5ZjTL95ZMEosQ6lfXdPfEr/9SUITPJFv9zFQ5RFSiHike2nuMt8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(136003)(346002)(39860400002)(366004)(186009)(1800799009)(451199024)(6636002)(66476007)(37006003)(66556008)(316002)(6512007)(66946007)(8676002)(8936002)(2616005)(6862004)(4326008)(36756003)(41300700001)(966005)(478600001)(6666004)(38100700002)(6506007)(6486002)(83380400001)(2906002)(86362001)(5660300002)(26005)(14773001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jCV0gxP+nStbJMDaD9NRZruIWwAwuCKZ2qTk6917PHrACgNXqOf4OvVUXvZ4?= =?us-ascii?Q?xT99McGMVNsq13YdoTBxtaplm1LFq2Mpu/qs1NTHBS0lpaG8egeaKTtIfdb8?= =?us-ascii?Q?2/IVaeAxqsD6a8tWuJuWBf5IeyqWtaOw4rDiiMbRy9wW3T29rCRIcUsGqowp?= =?us-ascii?Q?iesCyqpHna/f35h0oHGUrD0dB5JLtA5EuSa87qIBBrHIl8Qu6hipf7vym0qr?= =?us-ascii?Q?11XUqHV/RmAjhCUslzcfjRkEX7GI+GEbG6H69ACUhBnrONaDifNDJw//n6jj?= =?us-ascii?Q?Nu19lnsHp9srF0yCHyjZ7ci2SNMKkEsMXOPnS5MHE+ZTa6Y5u38zlsswYhbE?= =?us-ascii?Q?B+LYfXPU774tC/fWtvd915hy0/BrZmqwXJrRcESHEeDHL2LChpnVmEC+Skrl?= =?us-ascii?Q?sytgJn94f0ZW2u9YEJ+jIynEyC57Urq1rJ2v7mcs7KogVlauqZ7WofZ3i3qC?= =?us-ascii?Q?gH+t6u8huwfcE42KL7kIzWSstKtXOrCK/BFeV3eyZA8mAyuC7gyOL/zpjV2X?= =?us-ascii?Q?GamKbeAXhs00Thi3B0kwoemibP2+EZ4cHCrCYU+bnfreDQkFz6tPXCDyplZW?= =?us-ascii?Q?nRG9M5r6t+aax4Qiw19gkAuJ+wJldSqqpgBqTBoHXxl1a8d9KUCVAi4VQecL?= =?us-ascii?Q?3+q8ClcBNQFyenqAlz/gyL/9elwe5JqnH1g6DcB22l3woUrmtoNDQraTUz5V?= =?us-ascii?Q?/kMO08qjkoFFX4xvSL0oyjIHay+3z95vAOw9MlMYWXDCQxsU+zzV6l9sj4lL?= =?us-ascii?Q?oYQCc08z5RhbiqRC92Mt2/vXcnwFln2784NNqNwsadQL9wLgkb2/WCaNzbms?= =?us-ascii?Q?pwHRqelZWUgdY2HKZbMWjXoWotU5LuJ+VOpt3tZcmOFKn+9kHT8Rrjhyiinw?= =?us-ascii?Q?huwZl+McrRWozsDjsJZFrOVQsJn0zEObScoage7NOm5mXhhBZ5EiwFFJrVxY?= =?us-ascii?Q?GeBmIk8DTJryjWLzH5dSD7WO1Z3ShLZscfJr9UThNCcv3Wu1kS36YWR5SquP?= =?us-ascii?Q?ALrL2ZKYHsyKA5ABY3b4TL1lZNwmZLGf6CoU2JiDpS1SeinB+PaZnzNPJxD2?= =?us-ascii?Q?1DD6hAzWyzB43brDpa0+x0ry6+NOriBmD/yL8k6FAoXwJyLjI+/WEBf6SMzT?= =?us-ascii?Q?SGPVf7znVtJI6GvnqSho5WlUAIRKwD5HaK8pSIehq+b2ddnhMLDOSamZ1UH6?= =?us-ascii?Q?713lg5xDEVAmCQTFXkUANdTmNuz4EM1Lcveag47uCo/2qljdTJcWf2ZEAC9r?= =?us-ascii?Q?KdGHFwQfkVd/0xXwonLbTnTHm/UnPwzdNQUgu7Y++Sdw7B28FiiQRRfxX7yo?= =?us-ascii?Q?g+pzW2fhmCECYj3rO6zo6GJydISqZx0pYUbJo5K0w1jgUXsKI5SlTC6J3L6r?= =?us-ascii?Q?oH0kehq4ac250XMEAFvtpVzcaGs1/6987xseq8jhUdZ5jmKM981E5rO/a75Y?= =?us-ascii?Q?VfHUAGiff5g7ZFMmefVgDEozPThHFcb76IAHiKYUVXleBhOZXdim7lri06Jo?= =?us-ascii?Q?fVYatqYO8XP5TPYHF5+O/JFW4KyZ9GbEitesN7iiSvSB8jCwj8AV7208E4Fu?= =?us-ascii?Q?AbfxZd1xtTBokyB4Wb2qRHB9DuZwuGZ2pMhQykxe0vs2B2Vb+i5OZTJ0ARCQ?= =?us-ascii?Q?eQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zTI4c9VBowwkwAAi2X/4YI3Wbxs9W7shNXsL+gRtnDV6Ct3X9eAZIHeF0ZbBHWoEXFaakdmqEPMiB8Y6nHCnog1JnIx+mns1mEJoujwsXKBJ/w1lkZLAHLgl16rAWlpMi0Ysvh4rt2AI/ZP8EXLLL0WkhpfuKwgtH8BS/rszdlqLLj5w/0tETg03HAInh48qgxwwbmJ4Ky7Zr5RKAqszBwhan65NA0V7/5juyHODKV3BSmXYdeefITp0vsTOPRSTpbyaIoLI8eg9vcftGtlIlovE7cBZ3xS/klq/6RvzcKb+dhXfYAzEiqVpBc4oTGtzDVxi5NqEkm7+EPJqoIQiYHxdNIjwX4STB7NhtwBRjYTL8yCcmcZoNm4lDxg2SuIEu6OzX3QHbd/9YLZG/6MkqVlP25fEQ4aolEwNkOgE22sGDBFTCL29ElY/Xogl+YDQhpT8dHQdjrbD9I6K2H8GWBiIkmQIBhNan3t3ME4PdZ8JohMX6A3fcI+PDfnFnZv9+1pXAvocQPrJUFyrOu4eale8GttHlStItq2BftyJx2lKdCvnizwpL3ttM+JkDBWbqlm0HC1uWHfD8CzHmbWZ1beBbR/jww++4kih7tnm2jpt1H3fi5q/1RU78Qhyows1xLhaCGXERmhwpfydzBlGIZ5wlzcd1I176nyHyM6omnMRoIcxIk8kfJUy0zLAGufDnM+TsCkBYffiWxy9FzlL8T/GFsc/Y4dKK4/wUdEb9qr5JqO+dlyg0ZGWwBEOrTAr X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a001733f-4c77-4d96-24c4-08dba293170d X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 22:08:03.5210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k9BsJUJzyAzjHEUYJ1ix26BHZjW/doEk75XjyBMJ10lDpPPYEmj4hMPCW8KL1QCS93yGWkrUVhx9fKC+DdzeFATQnLhWqnOW+a8Ifddauvc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7931 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-21_10,2023-08-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308210203 X-Proofpoint-ORIG-GUID: 6WBozafa36HHTnZpSUeF2iA1_GC0CS0- X-Proofpoint-GUID: 6WBozafa36HHTnZpSUeF2iA1_GC0CS0- X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > The BPF virtual machine does not support neg nor neg32 instructions with > an immediate. > > The erroneous instructions were removed from binutils: > https://sourceware.org/pipermail/binutils/2023-August/129135.html > > Change the define_insn so that an immediate cannot be accepted. > > From testing, a neg-immediate was probably never chosen over a > mov-immediate anyway. OK. Thanks! > > Tested on x86_64-linux-gnu host for bpf-unknown-none target. > > gcc/ > > * config/bpf/bpf.md (neg): Second operand must be a register. > --- > gcc/config/bpf/bpf.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md > index a64de1095ed..e87d72182bb 100644 > --- a/gcc/config/bpf/bpf.md > +++ b/gcc/config/bpf/bpf.md > @@ -163,8 +163,8 @@ (define_insn "sub3" > > ;;; Negation > (define_insn "neg2" > - [(set (match_operand:AM 0 "register_operand" "=r,r") > - (neg:AM (match_operand:AM 1 "reg_or_imm_operand" " 0,I")))] > + [(set (match_operand:AM 0 "register_operand" "=r") > + (neg:AM (match_operand:AM 1 "register_operand" " 0")))] > "" > "{neg\t%0|%w0 = -%w1}" > [(set_attr "type" "")])