From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 44ACE3858D28 for ; Tue, 7 Dec 2021 21:18:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 44ACE3858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-CPkRfvwdM6C6uJvHo51G8A-1; Tue, 07 Dec 2021 16:18:48 -0500 X-MC-Unique: CPkRfvwdM6C6uJvHo51G8A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07950190B2A2; Tue, 7 Dec 2021 21:18:48 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFEAB60843; Tue, 7 Dec 2021 21:18:45 +0000 (UTC) From: Florian Weimer To: Jonathan Wakely via Libstdc++ Cc: gcc-patches@gcc.gnu.org, Jonathan Wakely Subject: Re: [PATCH] libstdc++: Allow std::condition_variable waits to be cancelled [PR103382] References: <20211207205803.1142706-1-jwakely@redhat.com> Date: Tue, 07 Dec 2021 22:18:43 +0100 In-Reply-To: <20211207205803.1142706-1-jwakely@redhat.com> (Jonathan Wakely via Libstdc's message of "Tue, 7 Dec 2021 20:58:03 +0000") Message-ID: <871r2onmfg.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 21:18:51 -0000 * Jonathan Wakely via Libstdc: > If necessary we could keep the terminate-on-cancellation behaviour as > _ZNSt18condition_variable4waitERSt11unique_lockISt5mutexE@GLIBCXX_3.4.11 > and export the new behaviour as @@GLIBCXX_3.4.30, although this patch > doesn't do that. Note that if this fix escapes into the wild and then you have to make the symbol version change, you will break newer applications. In a few cases in glibc, we proactively added aliases at a different symbol version, but with the same implementation (at first). Thanks, Florian