From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68422 invoked by alias); 31 Jan 2020 09:31:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68332 invoked by uid 89); 31 Jan 2020 09:31:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=emails, our X-HELO: esa3.mentor.iphmx.com Received: from esa3.mentor.iphmx.com (HELO esa3.mentor.iphmx.com) (68.232.137.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Jan 2020 09:31:18 +0000 IronPort-SDR: dsszMcqHxq7kSSafePqe9oqq3dD7s94ibyrhgBi2Hf5GPrKBGHbVB3HhBVZdDVvz1+hywX5tWS PTnM0/jWVlCvVKnKgybm6cr/J7ziehp/gRrS+sVMvP8rDdAfGPjzXTm05Z614Vun7krdjbwvkW SR+Dr8nEyGhDWnDOBlEBhapuMgzkONxbTbVr8gSfk2CeUglmyJK53toWM7Gc0USZQf+LEHqcgD +8Fx2Yb5FNkxK6L08Kz7pW2LAnA7xOh/dQcejOHeCGw3hgzLz7nkpVxUVqoPjM7lrDi+7tpLG0 04s= Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 31 Jan 2020 01:31:16 -0800 IronPort-SDR: uCj0dSCwulO2vmmQmhR1iW0NbOhrzcdwkynaaZ/IMs9xnVJB2j9HcI/EzACQHdD7ze2mMGwIs0 OrqPbMM6z81A== From: Thomas Schwinge To: Andrew Stubbs , Frederik Harwath CC: Jakub Jelinek , Subject: Re: [PATCH] Add OpenACC acc_get_property support for AMD GCN In-Reply-To: References: <0f59690f-5247-9b6e-169a-9a6ef16c41e1@codesourcery.com> <472b4749-7752-1527-c59c-1ab348854f32@codesourcery.com> <874kwdlyf7.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Fri, 31 Jan 2020 09:32:00 -0000 Message-ID: <871rrgm0q7.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-Path: tschwing@mentor.com X-SW-Source: 2020-01/txt/msg02059.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1148 Hi! On 2020-01-30T16:45:39+0000, Andrew Stubbs wrote: > On 30/01/2020 16:08, Thomas Schwinge wrote: >> Andrew and Frederik, thanks for your emails reminding/educating me about >> 'snprintf' as well as this HSA fixed-size buffer API. There doesn't >> happen to be something available in the HSA API available so that we >> could use 'sizeof [something]' instead of hard-coding '64' etc.? > > No, not at present; hsa_agent_get_info_fn is a somewhat generic=20 > interface that takes an enum and returns a void*. The return type is=20 > written in the documentation:=20 > https://rocm-documentation.readthedocs.io/en/latest/ROCm_API_References/R= OCr-API.html#rocr-api > > However, we don't use the official ROCm header files, because=20 > dependencies and licenses, so we could invent our own typedefs in hsa.h,= =20 > if we chose. I don't see that doing so would be worth the effort now, or= =20 > maintenance burden later. ACK. I was just curious if there's an easy way to properly resolve this "magic numbers" issue now, once and for all. Apparently, there isn't -- which shall be fine, then. Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 658 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEU9WEfWKGQazCmycCAKI7+41Q4XkFAl4z89AACgkQAKI7+41Q 4XmHvgv8CIuWmDM+Us0T9It0GIrWjKpFBOBA9IX82/TOkt8kkdMYH49WyvSWP4Ue OPn0yUaSBlfJwN7viRX6imc/Lw9bigArd8Cpbl2yeYsI3bPCYvZwikbEeFREe1Mx Voq0FJq911evLflzAsCFgfwfRW9+5oFjuKAczlETT7v/4q4kis+38ARYwhfOMoW+ Klu2VFxNPCsygw4KoT51W1az5oy23v53378fB1DdZ9cSpd26s9Nu75LE5cHCM0Fv crt+W+vHp51yEBEMeUalKVWMgaRPs8JXVK41kJJ36GcvC31Cs+2+s3rApJINqItt ZSz4cnFwh1/PehZ5QI21nwoYTOALxVut2xser/xX8ibtrVHiChH7AYHG5VtF+X0v Pd6qIv8tfgEOUSsCgPYTHpdAlHCHYF0SuZqE0UeEpAELdgam7GRJY1zuo30v7Tv/ 4PwudZtcNOIuGtrOas3kGT8RliXGA0cAhKJvYX4H21POZEWVGbJkaps/itK44nx5 kt/ubSjA =J7qz -----END PGP SIGNATURE----- --=-=-=--