From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14785 invoked by alias); 5 Jun 2014 15:31:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14767 invoked by uid 89); 5 Jun 2014 15:31:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 15:31:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s55FVVX5023447 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 5 Jun 2014 11:31:31 -0400 Received: from barimba ([10.3.113.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s55EcFkx032035 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 5 Jun 2014 10:38:16 -0400 From: Tom Tromey To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/5] introduce the binding oracle References: <1400254001-12038-1-git-send-email-tromey@redhat.com> <1400254001-12038-4-git-send-email-tromey@redhat.com> <5376632D.3000409@redhat.com> Date: Thu, 05 Jun 2014 15:31:00 -0000 In-Reply-To: <5376632D.3000409@redhat.com> (Jeff Law's message of "Fri, 16 May 2014 13:12:45 -0600") Message-ID: <871tv38lrc.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-06/txt/msg00494.txt.bz2 >>>>> "Jeff" == Jeff Law writes: Jeff> Just a nit. C-style comment would be appreciated. It might also help Jeff> to clarify what "much more sane" really means here. I made this change locally. The new comment reads: /* Temporarily hide any binding oracle. Without this, calls to debug_tree from the debugger will end up calling into the oracle, making for a confusing debug session. As the oracle isn't needed here for normal operation, it's simplest to suppress it. */ Tom