Re: [patch, mips] Size savings for MIPS16 switch statements

[Richard Sandiford <rdsandiford@googlemail.com>]

"Steve Ellcey " <sellcey@mips.com> writes:
> While doing some space optimization work with mips16 I found that using a
> larger case threshold value could shrink the code.  I did testing on some
> libraries like libpng and libjpeg as well as some test cases I wrote and
> came up with 10 as the best value for space savings in mips16 mode.  I did
> some testing of mips32 code as well and found that this change did not
> help with that code so I restricted the change to mips16 only.

Thanks for doing this.  casesi certainly isn't small, so I can believe
a larger threshold makes sense.  OK with a minor change:

> +/* Implement `CASE_VALUES_THRESHOLD'.  */
> +/* Supply the default for --param case-values-threshold=0  */
> +
> +unsigned int

Please just use:

/* Implement TARGET_CASE_VALUES_THRESHOLD.  */

instead of these two comments.

I was worried whether this would work for mips16 attributes, but it looks
like the function is called on demand rather than cached, so there should
be no problem there.

Thanks,
Richard