From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Steve Ellcey " <sellcey@mips.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, mips] Size savings for MIPS16 switch statements
Date: Tue, 23 Jul 2013 19:48:00 -0000 [thread overview]
Message-ID: <871u6pce1q.fsf@talisman.default> (raw)
In-Reply-To: <b1eb2749-d413-4f7f-9bb5-42e33787cd02@BAMAIL02.ba.imgtec.org> (Steve Ellcey's message of "Tue, 23 Jul 2013 10:25:51 -0700")
"Steve Ellcey " <sellcey@mips.com> writes:
> While doing some space optimization work with mips16 I found that using a
> larger case threshold value could shrink the code. I did testing on some
> libraries like libpng and libjpeg as well as some test cases I wrote and
> came up with 10 as the best value for space savings in mips16 mode. I did
> some testing of mips32 code as well and found that this change did not
> help with that code so I restricted the change to mips16 only.
Thanks for doing this. casesi certainly isn't small, so I can believe
a larger threshold makes sense. OK with a minor change:
> +/* Implement `CASE_VALUES_THRESHOLD'. */
> +/* Supply the default for --param case-values-threshold=0 */
> +
> +unsigned int
Please just use:
/* Implement TARGET_CASE_VALUES_THRESHOLD. */
instead of these two comments.
I was worried whether this would work for mips16 attributes, but it looks
like the function is called on demand rather than cached, so there should
be no problem there.
Thanks,
Richard
next prev parent reply other threads:[~2013-07-23 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 17:56 Steve Ellcey
2013-07-23 19:48 ` Richard Sandiford [this message]
2013-07-30 11:41 ` Maciej W. Rozycki
2013-07-30 16:56 ` Steve Ellcey
2013-07-30 18:47 ` Maciej W. Rozycki
2013-07-30 19:36 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u6pce1q.fsf@talisman.default \
--to=rdsandiford@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).