Re: PING: gcc.target/arm: skip 5 tests for flag conflicts

[Nick Clifton <nickc@redhat.com>]

Hi Janis,

> Back in September I submitted a patch to fix five ARM tests in
>  <http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01515.html>.
> You responded in < http://gcc.gnu.org/ml/gcc-patches/2012-10/msg00972.html>
> and I answered your questions in a reply.

I believe that Richard's main point was that the skips that you were
adding to the tests meant that they would not be run for valid
command line options.

Eg:

  Index: gcc.target/arm/pr53187.c
  ===================================================================
  --- gcc.target/arm/pr53187.c	(revision 191502)
  +++ gcc.target/arm/pr53187.c	(working copy)
  @@ -1,5 +1,6 @@
    /* PR target/53187 */
    /* { dg-do compile } */
  + /* { dg-skip-if "do not override -march" { *-*-* } { "-march=*" } { "-march=armv7-a" } } */
    /* { dg-options "-march=armv7-a -mfloat-abi=hard -O2" } */

With your patch applied this test will be skipped when, eg,
-march=armv7-r is specified as the multilib selector.  Or in fact any
-march that is not armv7-a, even though, for many of these, the test
will successfully compile.

Given that there are more compatible architectures than incompatible
ones, I think that it would be better to allow the test by default and
only exclude when necessary.  Eg:

    /* PR target/53187 */
    /* { dg-do compile } */
  + /* { dg-skip-if "incompatible -march" { *-*-* } { "-march=armv6s-m" "-march=armv6-m" } { "" } } */
    /* { dg-options "-march=armv7-a -mfloat-abi=hard -O2" } */

Cheers
  Nick