From: Jeff Law <law@redhat.com>
To: Matthias Klose <doko@ubuntu.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Andreas Schwab <schwab@suse.de>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Andrew Pinski <pinskia@gmail.com>,
Nicola Pero <nicola.pero@meta-innovation.com>
Subject: Re: [patch] boehm-gc removal and libobjc changes to build with an external bdw-gc
Date: Wed, 30 Nov 2016 17:27:00 -0000 [thread overview]
Message-ID: <8720b252-921d-0319-e83b-f2664f14dd6e@redhat.com> (raw)
In-Reply-To: <a995e123-a1af-3760-3c84-973592fe5e72@ubuntu.com>
On 11/30/2016 09:53 AM, Matthias Klose wrote:
> On 30.11.2016 12:38, Richard Biener wrote:
>> On Wed, Nov 30, 2016 at 12:30 PM, Matthias Klose <doko@ubuntu.com> wrote:
>>> There's one more fix needed for the case of only having the pkg-config module
>>> installed when configuring with --enable-objc-gc. We can't use PKG_CHECK_MODULES
>>> directly because the pkg.m4 macros choke on the dash in the module name. Thus
>>> setting the CFLAGS and LIBS directly. Ok to install?
>>
>> Why not fix pkg.m4?
>>
>> Richard.
>
> Jakub suggested to avoid using pkg-config at all, so we can get rid off this
> code altogether.
I thought we'd OK'd pkg-config (for JIT) which is why I didn't call it out.
Looking now, pkg-config got NAKd there and was removed.
Jeff
next prev parent reply other threads:[~2016-11-30 17:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 20:44 Matthias Klose
2016-11-30 8:30 ` Andreas Schwab
2016-11-30 10:06 ` Matthias Klose
2016-11-30 10:11 ` Andreas Schwab
2016-11-30 10:17 ` Richard Biener
2016-11-30 10:53 ` Jakub Jelinek
2016-11-30 11:13 ` Matthias Klose
2016-11-30 11:30 ` Matthias Klose
2016-11-30 11:38 ` Richard Biener
2016-11-30 12:08 ` Matthias Klose
2016-11-30 16:54 ` Matthias Klose
2016-11-30 17:27 ` Jeff Law [this message]
2016-12-01 12:32 ` Matthias Klose
2016-11-30 11:37 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8720b252-921d-0319-e83b-f2664f14dd6e@redhat.com \
--to=law@redhat.com \
--cc=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nicola.pero@meta-innovation.com \
--cc=pinskia@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).