public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Fix failure in test pr105586.c [PR107171]
@ 2022-10-13 17:02 Surya Kumari Jangala
  2022-10-26  2:47 ` Kewen.Lin
  0 siblings, 1 reply; 2+ messages in thread
From: Surya Kumari Jangala @ 2022-10-13 17:02 UTC (permalink / raw)
  To: gcc-patches; +Cc: Peter Bergner

testsuite: Fix failure in test pr105586.c [PR107171]

The test pr105586.c fails on a big endian system when run in 32bit
mode. The failure occurs as the test case does not guard against
unsupported __int128.

2022-10-13  Surya Kumari Jangala  <jskumari@linux.ibm.com>

gcc/testsuite/
	PR testsuite/107171
	* gcc.target/powerpc/pr105586.c: Guard against unsupported
	__int128.


diff --git a/gcc/testsuite/gcc.target/powerpc/pr105586.c b/gcc/testsuite/gcc.target/powerpc/pr105586.c
index bd397f5..3f88a09 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr105586.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr105586.c
@@ -1,4 +1,5 @@
 /* { dg-options "-mdejagnu-tune=power4 -O2 -fcompare-debug -fno-if-conversion -fno-guess-branch-probability" } */
+/* { dg-require-effective-target int128 } */
 
 extern int bar(int i);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: Fix failure in test pr105586.c [PR107171]
  2022-10-13 17:02 [PATCH] testsuite: Fix failure in test pr105586.c [PR107171] Surya Kumari Jangala
@ 2022-10-26  2:47 ` Kewen.Lin
  0 siblings, 0 replies; 2+ messages in thread
From: Kewen.Lin @ 2022-10-26  2:47 UTC (permalink / raw)
  To: Surya Kumari Jangala
  Cc: Peter Bergner, gcc-patches, Segher Boessenkool, David Edelsohn

Hi Surya,

on 2022/10/14 01:02, Surya Kumari Jangala via Gcc-patches wrote:
> testsuite: Fix failure in test pr105586.c [PR107171]
> 
> The test pr105586.c fails on a big endian system when run in 32bit
> mode. The failure occurs as the test case does not guard against
> unsupported __int128.
> 

I thought this is taken as an obvious fix and it didn't ask for a
review/approval, but I just noticed it's not committed yet, so I
assumed maybe you meant to ask for an approval?

Then this patch is OK, it's even obvious, thanks!

BR,
Kewen

> 2022-10-13  Surya Kumari Jangala  <jskumari@linux.ibm.com>
> 
> gcc/testsuite/
> 	PR testsuite/107171
> 	* gcc.target/powerpc/pr105586.c: Guard against unsupported
> 	__int128.
> 
> 
> diff --git a/gcc/testsuite/gcc.target/powerpc/pr105586.c b/gcc/testsuite/gcc.target/powerpc/pr105586.c
> index bd397f5..3f88a09 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr105586.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr105586.c
> @@ -1,4 +1,5 @@
>  /* { dg-options "-mdejagnu-tune=power4 -O2 -fcompare-debug -fno-if-conversion -fno-guess-branch-probability" } */
> +/* { dg-require-effective-target int128 } */
>  
>  extern int bar(int i);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-26  2:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 17:02 [PATCH] testsuite: Fix failure in test pr105586.c [PR107171] Surya Kumari Jangala
2022-10-26  2:47 ` Kewen.Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).