Re: [Patch] nvptx: Use fatal_error when -march= is missing not an assert [PR111093]

[Thomas Schwinge <thomas@codesourcery.com>]

Hi Tobias!

On 2023-10-16T11:18:45+0200, Tobias Burnus <tobias@codesourcery.com> wrote:
> While mkoffload ensures that there is always a -march=, nvptx's
> cc1 can also be run directly.
>
> In my case, I wanted to know which target-specific #define are
> available; hence, I did run:
>    accel/nvptx-none/cc1 -E -dM < /dev/null
> which gave an ICE. After some debugging, the reasons was
> clear (missing -march=) but somehow a (fatal) error would have been
> nicer than an ICE + debugging.
>
> OK for mainline?

Yes, thanks.  I think I prefer this over hard-coding some default
'ptx_isa_option' -- but may be convinced otherwise (incremental change),
if that's maybe more convenient for others?  (Roger?)


Grüße
 Thomas


> nvptx: Use fatal_error when -march= is missing not an assert [PR111093]
>
> gcc/ChangeLog:
>
>       PR target/111093
>       * config/nvptx/nvptx.cc (nvptx_option_override): Issue fatal error
>       instead of an assert ICE when no -march= has been specified.
>
> diff --git a/gcc/config/nvptx/nvptx.cc b/gcc/config/nvptx/nvptx.cc
> index edef39fb5e1..634c31673be 100644
> --- a/gcc/config/nvptx/nvptx.cc
> +++ b/gcc/config/nvptx/nvptx.cc
> @@ -335,8 +335,9 @@ nvptx_option_override (void)
>    init_machine_status = nvptx_init_machine_status;
>
>    /* Via nvptx 'OPTION_DEFAULT_SPECS', '-misa' always appears on the command
> -     line.  */
> -  gcc_checking_assert (OPTION_SET_P (ptx_isa_option));
> +     line; but handle the case that the compiler is not run via the driver.  */
> +  if (!OPTION_SET_P (ptx_isa_option))
> +    fatal_error (UNKNOWN_LOCATION, "%<-march=%> must be specified");
>
>    handle_ptx_version_option ();
>
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955