From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 15494385840A for ; Mon, 19 Dec 2022 12:13:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 15494385840A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.96,255,1665475200"; d="scan'208";a="90785790" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 19 Dec 2022 04:13:43 -0800 IronPort-SDR: SLIDlSFYmvG6nVJ386VXCQA96MqtI04tBCd7b9PqWNlcZYf5ekEdo/rhyx2Nl0RlbA+4Loj8E7 /0X+rutY1ZQNPHB7uqDmrWpM6sJgVqUZXd84u47sMG9fP7NfxrgrM6R1KOiE2HMdP1iqlTBomh yvwIRm/tYWiLepPz3YvzgyxVYbIQjzA1RE4+nqb9qB8Yz4OFsYVMSkRJYD396WtIZdHDWu4kTB hoygDCDto6xjyJ2ij2kbGRtfPP1c2vrdTv9M6CMIfiYphOZy49GY2nKF+Yx3sEuj4xloy5Lg+n Thg= From: Thomas Schwinge To: Tom de Vries , Chung-Lin Tang , Chung-Lin Tang CC: , Catherine Moore Subject: Re: [PATCH, nvptx, 1/2] Reimplement libgomp barriers for nvptx In-Reply-To: <041a398e-5d1f-cbfa-5d7c-12f46b330143@suse.de> References: <8b974d21-e288-4596-7500-277a43c92771@gmail.com> <041a398e-5d1f-cbfa-5d7c-12f46b330143@suse.de> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Mon, 19 Dec 2022 13:13:37 +0100 Message-ID: <87359b8uby.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2022-12-16T15:51:35+0100, Tom de Vries via Gcc-patches wrote: > On 9/21/22 09:45, Chung-Lin Tang wrote: >> I had a patch submitted earlier, where I reported that the current way >> of implementing >> barriers in libgomp on nvptx created a quite significant performance >> drop on some SPEChpc2021 >> benchmarks: >> https://gcc.gnu.org/pipermail/gcc-patches/2022-September/600818.html Also: my 2022-03-17 report in "[OpenMP/nvptx] Execution-time hang for simple nested OpenMP 'target'/'para= llel'/'task' constructs": . >> This patch has been tested on x86_64/powerpc64le with nvptx offloading, >> using libgomp, ovo, omptests, >> and sollve_vv testsuites, all without regressions. Also verified that >> the SPEChpc 2021 521.miniswp_t >> and 534.hpgmgfv_t performance regressions that occurred in the GCC12 >> cycle has been restored to >> devel/omp/gcc-11 (OG11) branch levels. I'm happy to confirm that this also does resolve the PR99555 issue mentioned above, so please do reference PR99555 in the commit log. >> Is this okay for trunk? > Yes, LGTM, please apply (after the other one). > > Thanks for addressing this. Thanks, Chung-Lin and Tom! >> (also suggest backporting to GCC12 branch, if performance regression can >> be considered a defect) > > That's ok, but wait a while after applying on trunk before doing that, > say a month. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955