Hi! Ping^2. Grüße Thomas On 2022-04-28T15:48:13+0200, I wrote: > Hi! > > Ping. > > On 2022-04-06T11:20:47+0200, I wrote: >> On 2021-01-14T15:50:23+0100, I wrote: >>> I'm raising here an issue with HSA libgomp plugin code changes from a >>> while ago. While HSA is now no longer relevant for GCC master branch, >>> the same code has also been copied into the GCN libgomp plugin. >> >> Here is another small clean-up patch (to enable further clean-up): >> >>> This is commit b8d89b03db5f212919e4571671ebb4f5f8b1e19d (r242749) "Remove >>> build dependence on HSA run-time": >>> >>> On 2016-11-22T14:27:44+0100, Martin Jambor wrote: >>>> --- a/libgomp/plugin/configfrag.ac >>>> +++ b/libgomp/plugin/configfrag.ac >>> >>>> @@ -195,8 +183,8 @@ if test x"$enable_offload_targets" != x; then >>>> tgt_name=hsa >>>> PLUGIN_HSA=$tgt >>>> PLUGIN_HSA_CPPFLAGS=$HSA_RUNTIME_CPPFLAGS >>>> - PLUGIN_HSA_LDFLAGS="$HSA_RUNTIME_LDFLAGS $HSA_KMT_LDFLAGS" >>>> - PLUGIN_HSA_LIBS="-lhsa-runtime64 -lhsakmt" >>>> + PLUGIN_HSA_LDFLAGS="$HSA_RUNTIME_LDFLAGS" >>>> + PLUGIN_HSA_LIBS="-ldl" >>> >>> So this switched from directly linking against 'libhsa-runtime64.so' to a >>> 'libdl'-based runtime linking variant. >> >> (Not intending to change anything regarding that.) >> >>> For avoidance of doubt, [an earlier] change doesn't affect (build-tree) testsuite >>> usage, where we have: >>> >>> libgomp/testsuite/libgomp-test-support.exp.in:set hsa_runtime_lib "@HSA_RUNTIME_LIB@" >>> >>> libgomp/testsuite/lib/libgomp.exp: append always_ld_library_path ":$hsa_runtime_lib" >> >> But, as I argue in the attached "libgomp testsuite: Don't amend >> 'LD_LIBRARY_PATH' for system-provided HSA Runtime library", we should >> actually clean this up as well. OK to push that? >> >> >> Grüße >> Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955