Re: [COMMITTED][patch][version 9]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 3485 bytes --]

Hi!

On 2021-09-10T10:47:00+0200, Christophe LYON via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> On 10/09/2021 00:49, Qing Zhao via Gcc-patches wrote:
>> I just committed the following patch to gcc upstream:
>>
>>
>> https://gcc.gnu.org/pipermail/gcc-cvs/2021-September/353195.html

> Several of the new tests fail on arm and aarch64 with -mabi=ilp32.

Similar for 32-bix x86 testing, or x86_64 with '-m32' testing -- as also
reported by a number of auto-tester instances.

> On arm:
>
> gcc:gcc.dg/dg.exp=c-c++-common/auto-init-1.c  -Wc++-compat   scan-tree-dump gimple "temp5 = .DEFERRED_INIT \\(8, 2, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-1.c  -Wc++-compat   scan-tree-dump gimple "temp7 = .DEFERRED_INIT \\(8, 2, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-2.c  -Wc++-compat   scan-tree-dump gimple "temp5 = .DEFERRED_INIT \\(8, 1, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-2.c  -Wc++-compat   scan-tree-dump gimple "temp7 = .DEFERRED_INIT \\(8, 1, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-3.c  -Wc++-compat   scan-tree-dump gimple "temp3 = .DEFERRED_INIT \\(16, 2, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-4.c  -Wc++-compat   scan-tree-dump gimple "temp3 = .DEFERRED_INIT \\(16, 1, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-5.c  -Wc++-compat   scan-tree-dump gimple "temp3 = .DEFERRED_INIT \\(32, 2, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-6.c  -Wc++-compat   scan-tree-dump gimple "temp3 = .DEFERRED_INIT \\(32, 1, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-padding-1.c  -Wc++-compat   scan-tree-dump gimple ".DEFERRED_INIT \\(24, 1, 0\\)"
>
> on aarch64 -mabi=ilp32:
>
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-1.c  -Wc++-compat   scan-tree-dump gimple "temp5 = .DEFERRED_INIT \\(8, 2, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-1.c  -Wc++-compat   scan-tree-dump gimple "temp7 = .DEFERRED_INIT \\(8, 2, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-2.c  -Wc++-compat   scan-tree-dump gimple "temp5 = .DEFERRED_INIT \\(8, 1, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-2.c  -Wc++-compat   scan-tree-dump gimple "temp7 = .DEFERRED_INIT \\(8, 1, 0\\)"
>      gcc:gcc.dg/dg.exp=c-c++-common/auto-init-padding-1.c  -Wc++-compat   scan-tree-dump gimple ".DEFERRED_INIT \\(24, 1, 0\\)"
>      gcc:gcc.target/aarch64/aarch64.exp=gcc.target/aarch64/auto-init-2.c scan-rtl-dump-times expand "0xfefefefefefefefe" 2
>      gcc:gcc.target/aarch64/aarch64.exp=gcc.target/aarch64/auto-init-padding-5.c scan-assembler-times stp\txzr, xzr, 2
>
> Can you check?

On 2021-09-10T11:08:22+0200, Martin Liška <mliska@suse.cz> wrote:
> It's the following bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102269

No, not ICEs, but just "regular 'scan-tree-dump' FAILs".  I suppose these
are all data-type mismatches: for example, 'long' or 'int *' not mapping
to the expected '8'.


Unrelated to the above, I've pushed as obvious
"Fix 'dg-do run' syntax in 'c-c++-common/auto-init-padding-{2,3}.c'"
to master branch in commit 5c5c2d86e520c3bf37368309b2fe932c88bdd14f, see
attached.  (All-PASS per my testing.)


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-dg-do-run-syntax-in-c-c-common-auto-init-padding.patch --]
[-- Type: text/x-diff, Size: 1957 bytes --]

From 5c5c2d86e520c3bf37368309b2fe932c88bdd14f Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Fri, 10 Sep 2021 11:26:50 +0200
Subject: [PATCH] Fix 'dg-do run' syntax in
 'c-c++-common/auto-init-padding-{2,3}.c'

Fix-up for recent commit a25e0b5e6ac8a77a71c229e0a7b744603365b0e9
 "Add -ftrivial-auto-var-init option and uninitialized variable attribute".

	gcc/testsuite/
	* c-c++-common/auto-init-padding-2.c: Fix 'dg-do run' syntax.
	* c-c++-common/auto-init-padding-3.c: Likewise.
---
 gcc/testsuite/c-c++-common/auto-init-padding-2.c | 2 +-
 gcc/testsuite/c-c++-common/auto-init-padding-3.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/c-c++-common/auto-init-padding-2.c b/gcc/testsuite/c-c++-common/auto-init-padding-2.c
index e2b50dc5ae8..462f5aeab91 100644
--- a/gcc/testsuite/c-c++-common/auto-init-padding-2.c
+++ b/gcc/testsuite/c-c++-common/auto-init-padding-2.c
@@ -1,7 +1,7 @@
 /* To test that the compiler can fill all the paddings to zeroes for the 
    structures when the auto variable is partially initialized,  fully 
    initialized, or not initialized for -ftrivial-auto-var-init=zero.  */
-/* { dg-do run} */
+/* { dg-do run } */
 /* { dg-options "-ftrivial-auto-var-init=zero" } */
 
 /* Structure with no padding. */
diff --git a/gcc/testsuite/c-c++-common/auto-init-padding-3.c b/gcc/testsuite/c-c++-common/auto-init-padding-3.c
index e2c48c002c9..22770142a95 100644
--- a/gcc/testsuite/c-c++-common/auto-init-padding-3.c
+++ b/gcc/testsuite/c-c++-common/auto-init-padding-3.c
@@ -1,7 +1,7 @@
 /* To test that the compiler can fill all the paddings to zeroes for the 
    structures when the auto variable is partially initialized,  fully 
    initialized, or not initialized for -ftrivial-auto-var-init=pattern.  */
-/* { dg-do run} */
+/* { dg-do run } */
 /* { dg-options "-ftrivial-auto-var-init=pattern" } */
 
 /* Structure with no padding. */
-- 
2.33.0