From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 2BE283858C39 for ; Fri, 10 Sep 2021 09:40:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2BE283858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: rNL5bO51vkgyRx1Qqjwnb3tQLGpbtuKPwaVs/1CU0a4pNFm5IjN79INX9A+/mJdIzMC3Y92WAL ZrBMjGjh2wHT0V2LZ7wVe2jB1x75+4l+r41Qf9B8aaRB8su2dOyx9U/RYwlyQpaGP1K0v4MH7R uoKv02c8zzxaJzzziLYwfe5nov5LbRZ2dzKkgrpqN4nmJot78VVmpqFKXDpkiX652vzir27j4D v7VFPuHqj8ZZTPmBkusl5gN+72ucxxVh0q4n2GvA3tFqiTuValFjeYzDWuZlPaejFnJ/bl3hsH 6fQXTzZjze9IpJdNSqcdlPCq X-IronPort-AV: E=Sophos;i="5.85,282,1624348800"; d="scan'208,223";a="65700870" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 10 Sep 2021 01:40:14 -0800 IronPort-SDR: m69MyXCbLFwUqxLNZT5IFIRs73mSM2pqMODl4R1ApRrcFtThc6rGGntpP8WyddD7geSguJVGOp E/7WsifZXKwwmDg0p+fHXtck/n8JCtIdk+w7fFpmghGPOlo5imGUDMsTO6b6+Bf2PFOax96Z5D Y47eAM05v9jaMkaWwrafmWZq4WS7sZhfPXMlErDxCNjMU37P0wXKoMFHR1JABpE12uM/7Oev3v czfl+ivhDzy4WjkyoP5F9H5O9F0zBoN/OdEMQnse0CMhP9kvGSslRPcSj2PzOxwxlvLdrGxMSY eus= From: Thomas Schwinge To: , Qing Zhao , Martin =?utf-8?Q?Li=C5=A1ka?= Subject: Re: [COMMITTED][patch][version 9]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Fri, 10 Sep 2021 11:40:06 +0200 Message-ID: <8735qc22h5.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 09:40:17 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! On 2021-09-10T10:47:00+0200, Christophe LYON via Gcc-patches wrote: > On 10/09/2021 00:49, Qing Zhao via Gcc-patches wrote: >> I just committed the following patch to gcc upstream: >> >> >> https://gcc.gnu.org/pipermail/gcc-cvs/2021-September/353195.html > Several of the new tests fail on arm and aarch64 with -mabi=3Dilp32. Similar for 32-bix x86 testing, or x86_64 with '-m32' testing -- as also reported by a number of auto-tester instances. > On arm: > > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-1.c -Wc++-compat scan-tree-= dump gimple "temp5 =3D .DEFERRED_INIT \\(8, 2, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-1.c -Wc++-compat scan-= tree-dump gimple "temp7 =3D .DEFERRED_INIT \\(8, 2, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-2.c -Wc++-compat scan-= tree-dump gimple "temp5 =3D .DEFERRED_INIT \\(8, 1, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-2.c -Wc++-compat scan-= tree-dump gimple "temp7 =3D .DEFERRED_INIT \\(8, 1, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-3.c -Wc++-compat scan-= tree-dump gimple "temp3 =3D .DEFERRED_INIT \\(16, 2, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-4.c -Wc++-compat scan-= tree-dump gimple "temp3 =3D .DEFERRED_INIT \\(16, 1, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-5.c -Wc++-compat scan-= tree-dump gimple "temp3 =3D .DEFERRED_INIT \\(32, 2, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-6.c -Wc++-compat scan-= tree-dump gimple "temp3 =3D .DEFERRED_INIT \\(32, 1, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-padding-1.c -Wc++-compat= scan-tree-dump gimple ".DEFERRED_INIT \\(24, 1, 0\\)" > > on aarch64 -mabi=3Dilp32: > > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-1.c -Wc++-compat scan-= tree-dump gimple "temp5 =3D .DEFERRED_INIT \\(8, 2, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-1.c -Wc++-compat scan-= tree-dump gimple "temp7 =3D .DEFERRED_INIT \\(8, 2, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-2.c -Wc++-compat scan-= tree-dump gimple "temp5 =3D .DEFERRED_INIT \\(8, 1, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-2.c -Wc++-compat scan-= tree-dump gimple "temp7 =3D .DEFERRED_INIT \\(8, 1, 0\\)" > gcc:gcc.dg/dg.exp=3Dc-c++-common/auto-init-padding-1.c -Wc++-compat= scan-tree-dump gimple ".DEFERRED_INIT \\(24, 1, 0\\)" > gcc:gcc.target/aarch64/aarch64.exp=3Dgcc.target/aarch64/auto-init-2.= c scan-rtl-dump-times expand "0xfefefefefefefefe" 2 > gcc:gcc.target/aarch64/aarch64.exp=3Dgcc.target/aarch64/auto-init-pa= dding-5.c scan-assembler-times stp\txzr, xzr, 2 > > Can you check? On 2021-09-10T11:08:22+0200, Martin Li=C5=A1ka wrote: > It's the following bug: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102269 No, not ICEs, but just "regular 'scan-tree-dump' FAILs". I suppose these are all data-type mismatches: for example, 'long' or 'int *' not mapping to the expected '8'. Unrelated to the above, I've pushed as obvious "Fix 'dg-do run' syntax in 'c-c++-common/auto-init-padding-{2,3}.c'" to master branch in commit 5c5c2d86e520c3bf37368309b2fe932c88bdd14f, see attached. (All-PASS per my testing.) Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-Fix-dg-do-run-syntax-in-c-c-common-auto-init-padding.patch" >From 5c5c2d86e520c3bf37368309b2fe932c88bdd14f Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 10 Sep 2021 11:26:50 +0200 Subject: [PATCH] Fix 'dg-do run' syntax in 'c-c++-common/auto-init-padding-{2,3}.c' Fix-up for recent commit a25e0b5e6ac8a77a71c229e0a7b744603365b0e9 "Add -ftrivial-auto-var-init option and uninitialized variable attribute". gcc/testsuite/ * c-c++-common/auto-init-padding-2.c: Fix 'dg-do run' syntax. * c-c++-common/auto-init-padding-3.c: Likewise. --- gcc/testsuite/c-c++-common/auto-init-padding-2.c | 2 +- gcc/testsuite/c-c++-common/auto-init-padding-3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/c-c++-common/auto-init-padding-2.c b/gcc/testsuite/c-c++-common/auto-init-padding-2.c index e2b50dc5ae8..462f5aeab91 100644 --- a/gcc/testsuite/c-c++-common/auto-init-padding-2.c +++ b/gcc/testsuite/c-c++-common/auto-init-padding-2.c @@ -1,7 +1,7 @@ /* To test that the compiler can fill all the paddings to zeroes for the structures when the auto variable is partially initialized, fully initialized, or not initialized for -ftrivial-auto-var-init=zero. */ -/* { dg-do run} */ +/* { dg-do run } */ /* { dg-options "-ftrivial-auto-var-init=zero" } */ /* Structure with no padding. */ diff --git a/gcc/testsuite/c-c++-common/auto-init-padding-3.c b/gcc/testsuite/c-c++-common/auto-init-padding-3.c index e2c48c002c9..22770142a95 100644 --- a/gcc/testsuite/c-c++-common/auto-init-padding-3.c +++ b/gcc/testsuite/c-c++-common/auto-init-padding-3.c @@ -1,7 +1,7 @@ /* To test that the compiler can fill all the paddings to zeroes for the structures when the auto variable is partially initialized, fully initialized, or not initialized for -ftrivial-auto-var-init=pattern. */ -/* { dg-do run} */ +/* { dg-do run } */ /* { dg-options "-ftrivial-auto-var-init=pattern" } */ /* Structure with no padding. */ -- 2.33.0 --=-=-=--