From: Richard Sandiford <rdsandiford@googlemail.com>
To: tbsaunde+gcc@tbsaunde.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 04/11] make recog () take a rtx_insn *
Date: Mon, 14 Nov 2016 20:24:00 -0000 [thread overview]
Message-ID: <8737itq07c.fsf@googlemail.com> (raw)
In-Reply-To: <20161114080934.19056-5-tbsaunde+gcc@tbsaunde.org> (tbsaunde's message of "Mon, 14 Nov 2016 03:09:27 -0500")
Thanks for doing this.
tbsaunde+gcc@tbsaunde.org writes:
> diff --git a/gcc/genrecog.c b/gcc/genrecog.c
> index a8e8c22..aa7f629 100644
> --- a/gcc/genrecog.c
> +++ b/gcc/genrecog.c
> @@ -5102,8 +5102,7 @@ print_subroutine (output_state *os, state *s, int proc_id)
> /* For now, the top-level "recog" takes a plain "rtx", and performs a
> checked cast to "rtx_insn *" for use throughout the rest of the
> function and the code it calls. */
> - const char *insn_param
> - = proc_id > 0 ? "rtx_insn *insn" : "rtx uncast_insn";
> + const char *insn_param = "rtx_insn *insn";
The comment is no longer true after the patch. We might as well just
get rid of the variable now that it's equal to a constant string of
almost the same length as the variable name.
Richard
next prev parent reply other threads:[~2016-11-14 20:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 8:01 [PATCH 00/11] more rtx_insn * stuff tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 04/11] make recog () take a rtx_insn * tbsaunde+gcc
2016-11-14 20:24 ` Richard Sandiford [this message]
2016-11-14 8:01 ` [PATCH 11/11] make find_reg{,no}_fusage take " tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 08/11] make prologue_epilogue_contains take a " tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 02/11] split up variables to use rtx_insn * more tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 01/11] use rtx_insn * more places where it is obvious tbsaunde+gcc
2016-11-22 10:10 ` Andreas Schwab
2016-11-23 20:17 ` Jeff Law
2016-11-14 8:01 ` [PATCH 09/11] make add_int_reg_note take rtx_insn * tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 03/11] make find_reg_equal_equiv_note " tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 05/11] make replace_label_in_insn take labels as " tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 10/11] make dead_or_set_{,regno_}p take " tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 07/11] remove cast from emit_libcall_block tbsaunde+gcc
2016-11-14 8:01 ` [PATCH 06/11] make delete_insn () take a rtx_insn * tbsaunde+gcc
2016-11-14 13:45 ` [PATCH 00/11] more rtx_insn * stuff Bernd Schmidt
2016-11-14 15:18 ` Trevor Saunders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737itq07c.fsf@googlemail.com \
--to=rdsandiford@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tbsaunde+gcc@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).