From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118398 invoked by alias); 9 Oct 2015 14:00:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117274 invoked by uid 89); 9 Oct 2015 14:00:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Oct 2015 14:00:01 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZkYDG-0002Zq-3m from Thomas_Schwinge@mentor.com ; Fri, 09 Oct 2015 06:59:58 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Fri, 9 Oct 2015 14:59:08 +0100 From: Thomas Schwinge To: Nathan Sidwell CC: Jakub Jelinek , James Norris , Cesar Philippidis , , "Jason Merrill" , Joseph Myers Subject: Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++ In-Reply-To: <5617C27B.9040706@acm.org> References: <87h9m1nwle.fsf@kepler.schwinge.homeip.net> <5617B27D.7010602@acm.org> <87bnc8cgw6.fsf@schwinge.name> <5617C27B.9040706@acm.org> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 09 Oct 2015 14:00:00 -0000 Message-ID: <8737xkcfdg.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-10/txt/msg00977.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 818 Hi Nathan! On Fri, 9 Oct 2015 09:34:51 -0400, Nathan Sidwell wrote: > On 10/09/15 09:26, Thomas Schwinge wrote: > > You mean the cp_parser_oacc_loop and cp_parser_oacc_kernels_parallel > > functions need documentation? I agree it's a bit terse, but documenting > > these by just listing the accepted parsing tokens "# pragma acc loop" > > etc., followed by the *_CLAUSE_MASKs is what's done for the other > > OpenACC/OpenMP directives in the C/C++ front ends. So, I don't see a > > reason to be different for these two? >=20 >=20 > What's the p_name argument for? It's s string describing the pragma as parsed thus far. Again, not documenting that as well as our usage of it is totally "standard", see OpenMP's cp_parser_omp_parallel, cp_parser_omp_for, and many more. Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWF8grAAoJEPoxNhtoi6COk7UH/1lHdFAEn8mh8hV4EZJH9tpx ovXV6IKddgNTGvMKztuVSX4USli4JIvIZZGZnXsFzd0b2+Unje29N2PHbx+ORA5M 2+wveQYmkCUD39QaotJAvNyKa9l8RiCn4CHOORc9FNLg8+w2VSxhbnIaILbUqV8s vM0XMvtjq6jtPCoLeKQokt/IhdwG9RCflBu49fPfZ0if+LwRZTM090DTAOc/fVv8 I4A8tjBy6rOCX+UP0+62i5nSzNwINj1gY0/By6fDPG/AavRcnAZ6XAgd2f42x7ET 3/rcqIv5QdltNN+2SgqgrxqQN4cU2lKTeNSZc3jfojyoJfakVJ1wN1Mo6U8/E1U= =4n2+ -----END PGP SIGNATURE----- --=-=-=--