From: Richard Sandiford <richard.sandiford@arm.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org,
Marcus Shawcroft <marcus.shawcroft@gmail.com>,
Jeff Law <law@redhat.com>, Alan Hayward <Alan.Hayward@arm.com>,
"steven\@gcc.gnu.org" <steven@gcc.gnu.org>
Subject: Re: [PATCH][rtlanal.c][BE][1/2] Fix vector load/stores to not use ld1/st1
Date: Wed, 21 Jan 2015 18:03:00 -0000 [thread overview]
Message-ID: <873874rpf4.fsf@e105548-lin.cambridge.arm.com> (raw)
In-Reply-To: <1695077.g5BBHXBRRL@polaris> (Eric Botcazou's message of "Tue, 20 Jan 2015 23:50:11 +0100")
Eric Botcazou <ebotcazou@adacore.com> writes:
>> Seems like the thread might have died down, so just wanted to ping it.
>> As Marcus says, this is holding up other patches so it'd be good to get
>> something in soon. Would it be OK to commit the original patch or should
>> we wait?
>
> Yes, go ahead, but add a FIXME or ??? comment.
Thanks, here's what I installed.
Richard
gcc/
2015-01-25 Alan Hayward <alan.hayward@arm.com>
* rtlanal.c (subreg_get_info): Exit early for simple and common
cases.
Index: gcc/rtlanal.c
===================================================================
--- gcc/rtlanal.c 2015-01-21 17:06:33.594664514 +0000
+++ gcc/rtlanal.c 2015-01-21 17:10:22.863830284 +0000
@@ -3440,6 +3440,22 @@ subreg_get_info (unsigned int xregno, ma
info->offset = offset / regsize_xmode;
return;
}
+ /* Quick exit for the simple and common case of extracting whole
+ subregisters from a multiregister value. */
+ /* ??? It would be better to integrate this into the code below,
+ if we can generalize the concept enough and figure out how
+ odd-sized modes can coexist with the other weird cases we support. */
+ if (!rknown
+ && WORDS_BIG_ENDIAN == REG_WORDS_BIG_ENDIAN
+ && regsize_xmode == regsize_ymode
+ && (offset % regsize_ymode) == 0)
+ {
+ info->representable_p = true;
+ info->nregs = nregs_ymode;
+ info->offset = offset / regsize_ymode;
+ gcc_assert (info->offset + info->nregs <= nregs_xmode);
+ return;
+ }
}
/* Lowpart subregs are otherwise valid. */
next prev parent reply other threads:[~2015-01-21 17:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 11:08 Alan Hayward
2014-12-12 16:21 ` Richard Sandiford
2014-12-13 11:34 ` Eric Botcazou
2014-12-15 9:21 ` Richard Sandiford
2014-12-15 20:52 ` Eric Botcazou
2014-12-15 21:56 ` Richard Sandiford
2014-12-19 22:53 ` Eric Botcazou
2015-01-10 14:59 ` Richard Sandiford
2015-01-13 19:04 ` Eric Botcazou
2015-01-14 8:37 ` Jeff Law
2015-01-14 9:55 ` Marcus Shawcroft
2015-01-20 21:45 ` Richard Sandiford
2015-01-21 1:48 ` Eric Botcazou
2015-01-21 18:03 ` Richard Sandiford [this message]
2015-01-14 7:48 ` Jeff Law
2015-01-09 7:12 ` Jeff Law
-- strict thread matches above, loose matches on Subject: below --
2014-12-10 9:51 Alan Hayward
2014-12-10 10:25 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873874rpf4.fsf@e105548-lin.cambridge.arm.com \
--to=richard.sandiford@arm.com \
--cc=Alan.Hayward@arm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=marcus.shawcroft@gmail.com \
--cc=steven@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).