From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6429 invoked by alias); 29 Sep 2014 18:13:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6417 invoked by uid 89); 29 Sep 2014 18:13:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Sep 2014 18:13:36 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-03.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XYfS0-0005Wv-Qn from Thomas_Schwinge@mentor.com ; Mon, 29 Sep 2014 11:13:33 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-03.mgc.mentorg.com (137.202.0.108) with Microsoft SMTP Server id 14.3.181.6; Mon, 29 Sep 2014 19:13:31 +0100 From: Thomas Schwinge To: "Iyer, Balaji V" , , CC: Subject: libcilkrts: Remove unused function __cilkrts_sysdep_is_worker_thread_id (was: Cilk Library) In-Reply-To: References: <525460A9.2040409@redhat.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (i486-pc-linux-gnu) Date: Mon, 29 Sep 2014 18:13:00 -0000 Message-ID: <8738bae1mp.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2014-09/txt/msg02569.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1739 Hi! On Wed, 9 Oct 2013 18:32:11 +0000, "Iyer, Balaji V" wrote: > [libcilkrts] I have found a function that is -- as far as I can tell -- unused, and I'm thus proposing to remove it. This increases portability, as this code has dependencies on the operating system. Tested on x86 GNU/Hurd, and x86_64 GNU/Linux is in progress. OK for trunk once testing completed? commit 4f32339be3c95330b7fcd3bc6bb520a7401aa510 Author: Thomas Schwinge Date: Sat Sep 20 19:53:56 2014 +0200 libcilkrts: Remove unused function __cilkrts_sysdep_is_worker_thread_id. =20=20=20=20 libcilkrts/ * runtime/sysdep-unix.c (__cilkrts_sysdep_is_worker_thread_id): Remove function. --- libcilkrts/runtime/sysdep-unix.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git libcilkrts/runtime/sysdep-unix.c libcilkrts/runtime/sysdep-unix.c index 1f82b62..b9f1ad0 100644 --- libcilkrts/runtime/sysdep-unix.c +++ libcilkrts/runtime/sysdep-unix.c @@ -571,28 +571,6 @@ void __cilkrts_make_unrunnable_sysdep(__cilkrts_worker= *w, } } =20 -/* - * __cilkrts_sysdep_is_worker_thread_id - * - * Returns true if the thread ID specified matches the thread ID we saved - * for a worker. - */ - -int __cilkrts_sysdep_is_worker_thread_id(global_state_t *g, - int i, - void *thread_id) -{ -#if defined( __linux__) || defined(__VXWORKS__) - pthread_t tid =3D *(pthread_t *)thread_id; - if (i < 0 || i > g->total_workers) - return 0; - return g->sysdep->threads[i] =3D=3D tid; -#else - // Needs to be implemented - return 0; -#endif -} - =20 =20 =20 Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUKaE+AAoJEK3/DN1sMFFtee4H/RjAYNBYhL25T4YcBDSVpZAR yP/12P0JVsN7WJbPY4rcaHOaJf4SSxoBAb2wx7A7mNGILJCcecQzBL62xhHmVvoh c63knk2BaN8Nfk+kwQ1v9F3e1CHmXRPYNhbSrCuzoQGdercRASPt4HSk2KqXU+FO MsQlRBknBew9rAutJT0Fu9cONNYah1YtoiJQKtcYxwXb8zc4mHs/XkN9xcyhqKrj cK1vImPNi3fEGt1kHnpVmLxqrsrM2Xyldoq4Pd4hoMks2d1iXQPhCVo68rgChNQA PQpcxRPoGg293TFONcNYt8oD2kNgCE5esM+RC/ZZVlU7lKuSNOgQZSr0Fe9BA7U= =h0In -----END PGP SIGNATURE----- --=-=-=--