Re: Extend widening_mul pass to handle fixed-point types

[Richard Sandiford <rdsandiford@googlemail.com>]

Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> writes:
>> Could you give the attached patch a try?  It also fixes a case where
>> the code could create mixed sign-and-unsigned maccs (a bug that existed
>> before my patch) and a botched call to is_widening_mult_p (a bug
>> introduced by my patch, sorry).
>
> Your patch didn't apply cleanly to pristine trunk or to 162431 and I had
> to do a manual merge so I'm not sure if I got all parts of it. 
>
> Just to be absolutely clear, you still need to check for
> is_gimple_assign before using the stmt in gimple_assign_lhs in
> is_widening_mult_p or do you expect that to get subsumed by your patch ?
> Otherwise the compiler ICEs with this testcase [ice-on-gimple-phi.c]. 

For the record -- since I accidentally took this off-list when I started
using the gmail web interface, sorry about that -- the problems Ramana
had applying the patch were due to some kind of mailer issue.  The ICE
in ice-on-gimple-phi.c was due to the s/rhs1_stmt/rhs2_stmt/ part being
missing from the manually-applied patch.

Richard