public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH]: Fix mips breakage after fdl-pool patch
@ 2007-08-15 13:09 Maxim Kuvyrkov
  2007-08-15 13:27 ` Richard Sandiford
  0 siblings, 1 reply; 2+ messages in thread
From: Maxim Kuvyrkov @ 2007-08-15 13:09 UTC (permalink / raw)
  To: Richard Sandiford; +Cc: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hello Richard,

I broke mips backend with my last scheduler patch that changed interface 
to scheduler dependency analyzer (sched-deps.c).

This obvious patch fixes things by changing mips backend to use new 
interface.

I audited other targets for the same error and they appear to be fine.

Ok for trunk?


Thanks,

Maxim

[-- Attachment #2: fdl-pool-mips.ChangeLog --]
[-- Type: text/plain, Size: 145 bytes --]

2007-08-15  Maxim Kuvyrkov  <maxim@codesourcery.com>

	* config/mips/mips.c (vr4130_swap_insns_p): Use new interface to
	scheduler dependencies.

[-- Attachment #3: fdl-pool-mips.patch --]
[-- Type: text/x-patch, Size: 1165 bytes --]

Index: config/mips/mips.c
===================================================================
--- config/mips/mips.c	(revision 127511)
+++ config/mips/mips.c	(working copy)
@@ -10930,7 +10930,8 @@ vr4130_true_reg_dependence_p (rtx insn)
 static bool
 vr4130_swap_insns_p (rtx insn1, rtx insn2)
 {
-  dep_link_t dep;
+  sd_iterator_def sd_it;
+  dep_t dep;
 
   /* Check for the following case:
 
@@ -10940,11 +10941,11 @@ vr4130_swap_insns_p (rtx insn1, rtx insn
 
      If INSN1 is the last instruction blocking X, it would better to
      choose (INSN1, X) over (INSN2, INSN1).  */
-  FOR_EACH_DEP_LINK (dep, INSN_FORW_DEPS (insn1))
-    if (DEP_LINK_KIND (dep) == REG_DEP_ANTI
-	&& INSN_PRIORITY (DEP_LINK_CON (dep)) > INSN_PRIORITY (insn2)
-	&& recog_memoized (DEP_LINK_CON (dep)) >= 0
-	&& get_attr_vr4130_class (DEP_LINK_CON (dep)) == VR4130_CLASS_ALU)
+  FOR_EACH_DEP (insn1, SD_LIST_FORW, sd_it, dep)
+    if (DEP_TYPE (dep) == REG_DEP_ANTI
+	&& INSN_PRIORITY (DEP_CON (dep)) > INSN_PRIORITY (insn2)
+	&& recog_memoized (DEP_CON (dep)) >= 0
+	&& get_attr_vr4130_class (DEP_CON (dep)) == VR4130_CLASS_ALU)
       return false;
 
   if (vr4130_last_insn != 0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH]: Fix mips breakage after fdl-pool patch
  2007-08-15 13:09 [PATCH]: Fix mips breakage after fdl-pool patch Maxim Kuvyrkov
@ 2007-08-15 13:27 ` Richard Sandiford
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2007-08-15 13:27 UTC (permalink / raw)
  To: Maxim Kuvyrkov; +Cc: gcc-patches

Maxim Kuvyrkov <maxim@codesourcery.com> writes:
> Hello Richard,
>
> I broke mips backend with my last scheduler patch that changed interface 
> to scheduler dependency analyzer (sched-deps.c).
>
> This obvious patch fixes things by changing mips backend to use new 
> interface.
>
> I audited other targets for the same error and they appear to be fine.
>
> Ok for trunk?

Yes, thanks.

Richard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-15 13:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-15 13:09 [PATCH]: Fix mips breakage after fdl-pool patch Maxim Kuvyrkov
2007-08-15 13:27 ` Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).