From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id E3E103858D1E for ; Sat, 1 Oct 2022 00:50:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3E103858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ventanamicro.com Received: by mail-pl1-x635.google.com with SMTP id v1so5273941plo.9 for ; Fri, 30 Sep 2022 17:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date; bh=iT8WT6ycXOFbqj9kaRXfMKFfNWqzqmP90SSmPsZaZ0o=; b=VZJ5xv0w4lujLaQH8U00KF9qkUTjXkb6LiHLWkScWdcApgrqCMA9LYKq4xtJJJ8qU2 QmlklOOfNQ+MVC9a4zDI/UpVcXoZ3X/O01fR3Z9SY6D5BdKVfMAO0ANQeInS4QB331+N lPvXpRpGdeVqQ78opitedMDLLUO2VT321X4vycSQ8dbSYTnuOxX2ekxHL+XyVehpmqa+ CapF3oHzPgDaKa0rCh5WTEg7TDSdt5uJaSrshvr22CA8YD/he5BTK6xHQevayAVcn5P4 1gBWeN0L7ZkHna3lrYcKEuNMqg+SVzSURgzqMK0KFot+eZQ9qHHzByyeRXFbNUq1fSh9 W6Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date; bh=iT8WT6ycXOFbqj9kaRXfMKFfNWqzqmP90SSmPsZaZ0o=; b=AELSyWdy9q2yU9ofd2HMxuigDLru0X+fubGWiuBgSbdT/PwuO/hHBH/5HTI1Mo8FW8 Ef6YmD2SrwylI22ggbi9a0+4Gi+I2z24GkFNkoanPGfQ/2dtonfyYrkc7pHtprjtj419 PdTi2/1g4TIxI3gHIZ3zzBvbULxuUhRzLLXWTpF2Yfi0L4kP9VaAYoFXimPsnHIC3ij7 T+1kRA2RP0KOF/3nriuiLZF/PPRD96Na/QbV0ugj+G3qckNsYI0M/75l9QQGGlVEfP1Y Wz/vpBAtEgT0U+fFpNihMnc+mDK6iVd+7lMvA9h8NCAdFclMeEoAZwNgC31+IdHSH9s1 onKQ== X-Gm-Message-State: ACrzQf2IC29z9aoSqWWairf1LXkniE+2PCaIdYm0IUOXECsQ6v/WAxgZ l5LpIgwCsP8nX04xKxtrwwypVDx81OqSYgdh X-Google-Smtp-Source: AMsMyM5BTLeR8uXV1QAvZRpDT/fMn5xup2TSN40wNP57oAdKZOVHqMCzeVhhyuTSUXeU/kbN45/Z1A== X-Received: by 2002:a17:90b:164b:b0:202:d347:2512 with SMTP id il11-20020a17090b164b00b00202d3472512mr948956pjb.185.1664585432746; Fri, 30 Sep 2022 17:50:32 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id o11-20020a62f90b000000b0053b850b17c8sm2430682pfh.152.2022.09.30.17.50.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 17:50:32 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0YapDNf2a7118uyZBlAbT1IO" Message-ID: <873b545e-d30c-4797-f467-ccff8644b54d@ventanamicro.com> Date: Fri, 30 Sep 2022 18:50:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [committed] Minor cleanup/prep in DOM Content-Language: en-US To: "H.J. Lu" Cc: "gcc-patches@gcc.gnu.org" References: <44815a60-2cd4-9408-64a9-d718163bca71@ventanamicro.com> From: Jeff Law In-Reply-To: X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------0YapDNf2a7118uyZBlAbT1IO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/30/22 18:07, H.J. Lu wrote: > On Fri, Sep 30, 2022 at 4:06 PM Jeff Law wrote: >> >> It's a bit weird that free_dom_edge_info leaves a dangling pointer in >> e->aux. Not sure what I was thinking. >> >> >> There's two callers. One wipes e->aux immediately after the call, the >> other attaches a newly created object immediately after the call. So we >> can wipe e->aux within the call and simplify one of the two call sites. >> >> This is preparatory work for a minor optimization where we want to >> detect another class of edge equivalences in DOM (until something better >> is available) and either attach them an existing edge_info structure or >> create a new one if one doesn't currently exist for a given edge. >> >> Bootstrapped and regression tested on x86_64. Installing on the trunk. >> > I got [ ... ] Pushed wrong version.  Sorry about that.  Fixed by attached patch which just moves the test down to its proper position. Jeff --------------0YapDNf2a7118uyZBlAbT1IO Content-Type: text/plain; charset=UTF-8; name="P" Content-Disposition: attachment; filename="P" Content-Transfer-Encoding: base64 Y29tbWl0IGFhMzYwZmJmNjhiMTFlNTQwMTdlOGZhNWIxYmRiODdjZTdjMTkxODgKQXV0aG9y OiBKZWZmIExhdyA8amVmZnJleWFsYXdAZ21haWwuY29tPgpEYXRlOiAgIEZyaSBTZXAgMzAg MjA6NDY6MDQgMjAyMiAtMDQwMAoKICAgIEluc3RhbGwgY29ycmVjdCBwYXRjaCB2ZXJzaW9u LgogICAgCiAgICBnY2MvCiAgICAgICAgICAgICogdHJlZS1zc2EtZG9tLmNjIChyZWNvcmRf ZWRnZV9pbmZvKTogSW5zdGFsbCBjb3JyZWN0IHZlcnNpb24gb2YKICAgICAgICAgICAgcGF0 Y2guCgpkaWZmIC0tZ2l0IGEvZ2NjL3RyZWUtc3NhLWRvbS5jYyBiL2djYy90cmVlLXNzYS1k b20uY2MKaW5kZXggOGQ4MzEyY2EzNTAuLmU2YjhkYWNlNWU5IDEwMDY0NAotLS0gYS9nY2Mv dHJlZS1zc2EtZG9tLmNjCisrKyBiL2djYy90cmVlLXNzYS1kb20uY2MKQEAgLTY4NCwxMSAr Njg0LDYgQEAgcmVjb3JkX2VkZ2VfaW5mbyAoYmFzaWNfYmxvY2sgYmIpCiAJCSAgICAgICAh Z3NpX2VuZF9wIChnc2kpOwogCQkgICAgICAgZ3NpX25leHQgKCZnc2kpKQogCQkgICAgewot CQkgICAgICAvKiBJZiB0aGUgb3RoZXIgYWx0ZXJuYXRpdmUgaXMgdGhlIHNhbWUgYXMgdGhl IHJlc3VsdCwKLQkJCSB0aGVuIHRoaXMgaXMgYSBkZWdlbmVyYXRlIGFuZCBjYW4gYmUgaWdu b3JlZC4gICovCi0JCSAgICAgIGlmIChkc3QgPT0gUEhJX0FSR19ERUYgKHBoaSwgIWFsdGVy bmF0aXZlKSkKLQkJCWNvbnRpbnVlOwotCiAJCSAgICAgIC8qIE5vdyBnZXQgdGhlIEVER0Vf SU5GTyBjbGFzcyBzbyB3ZSBjYW4gYXBwZW5kCiAJCQkgaXQgdG8gb3VyIGxpc3QuICBXZSB3 YW50IHRoZSBzdWNjZXNzb3IgZWRnZQogCQkJIHdoZXJlIHRoZSBkZXN0aW5hdGlvbiBpcyBu b3QgdGhlIHNvdXJjZSBvZgpAQCAtNjk3LDYgKzY5MiwxMSBAQCByZWNvcmRfZWRnZV9pbmZv IChiYXNpY19ibG9jayBiYikKIAkJICAgICAgdHJlZSBzcmMgPSBQSElfQVJHX0RFRiAocGhp LCBhbHRlcm5hdGl2ZSk7CiAJCSAgICAgIHRyZWUgZHN0ID0gUEhJX1JFU1VMVCAocGhpKTsK IAorCQkgICAgICAvKiBJZiB0aGUgb3RoZXIgYWx0ZXJuYXRpdmUgaXMgdGhlIHNhbWUgYXMg dGhlIHJlc3VsdCwKKwkJCSB0aGVuIHRoaXMgaXMgYSBkZWdlbmVyYXRlIGFuZCBjYW4gYmUg aWdub3JlZC4gICovCisJCSAgICAgIGlmIChkc3QgPT0gUEhJX0FSR19ERUYgKHBoaSwgIWFs dGVybmF0aXZlKSkKKwkJCWNvbnRpbnVlOworCiAJCSAgICAgIGlmIChFREdFX1NVQ0MgKGJi LCAwKS0+ZGVzdAogCQkJICAhPSBFREdFX1BSRUQgKGJiLCAhYWx0ZXJuYXRpdmUpLT5zcmMp CiAJCQllZGdlX2luZm8gPSAoY2xhc3MgZWRnZV9pbmZvICopRURHRV9TVUNDIChiYiwgMCkt PmF1eDsK --------------0YapDNf2a7118uyZBlAbT1IO--