From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id A83E33858D35 for ; Thu, 7 Mar 2024 09:51:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A83E33858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A83E33858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709805085; cv=none; b=ASdZqWcCYwJUNbByoZeqQvId1HFr2br1yd6QmO9VGWDrOf6Yg8wv87CmYO/Ol5857D+V3ODt/ngMv/z7DfSo3s7dUfi1gYED91pXPIAbZewILuiFQFByYXF4PbfhguSLALEH2b5UEscoxrvOrru/C08Eed6MGB5TW8vSN9lFQ+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709805085; c=relaxed/simple; bh=gCeD/v69Uo7+yAwT5CdVzFcH+ch8nqDJVlMKjgiEpkM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=FfeMm1GbTXHvlR6u9tEz3BsFlEAsyh2D3LKVlPtyBraX3k+szYJfSppYzOa6JchNRIrhAyCqXR8vzyK53JWJE/UJ1OSgQFb2IlqsR5wBflwhdRTZU0WcK04yD7aGXVQlSIGU46Lp+hq8FW5pbKg6NPy+KFVrdqlJR5YhHpvSf3k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6E9821F456; Thu, 7 Mar 2024 09:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709805078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BssxX0HZvNtUAzt8m/g8s7ZBQWfGGpawNW5rHQ/Rwgo=; b=Bdj4qYoskIYRCSf/nH+HgEmmuG1NNk71j2n6EGKJ8KNEEFrEV9K4Rerai1wcwg+wDat1xR cu5PDgesq7aY208yLkbAhR2+E7sEyhEO51nrv9lNOI2FDzv2IFZ6sKJPeeW9n09YBlLKWl QI0AAbjx/VftyZzJOs8pYkfctzrZJ6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709805078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BssxX0HZvNtUAzt8m/g8s7ZBQWfGGpawNW5rHQ/Rwgo=; b=JniFQtP2yGx/F532BYwmvqJoHwvPnUO3vG+QRSv3av9x7/1f8T3jvUhGhEn6Ofez6naoVU yAhiiAy8C/xQlVBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709805078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BssxX0HZvNtUAzt8m/g8s7ZBQWfGGpawNW5rHQ/Rwgo=; b=Bdj4qYoskIYRCSf/nH+HgEmmuG1NNk71j2n6EGKJ8KNEEFrEV9K4Rerai1wcwg+wDat1xR cu5PDgesq7aY208yLkbAhR2+E7sEyhEO51nrv9lNOI2FDzv2IFZ6sKJPeeW9n09YBlLKWl QI0AAbjx/VftyZzJOs8pYkfctzrZJ6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709805078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BssxX0HZvNtUAzt8m/g8s7ZBQWfGGpawNW5rHQ/Rwgo=; b=JniFQtP2yGx/F532BYwmvqJoHwvPnUO3vG+QRSv3av9x7/1f8T3jvUhGhEn6Ofez6naoVU yAhiiAy8C/xQlVBQ== Date: Thu, 7 Mar 2024 10:51:18 +0100 (CET) From: Richard Biener To: Iain Sandoe cc: Dimitry Andric , FX Coudert , Sam James , GCC Patches Subject: Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning In-Reply-To: Message-ID: <874745n3-3q25-87n4-6502-2p17r52ps0on@fhfr.qr> References: <878r2v1n5o.fsf@gentoo.org> <06E40B8A-8716-4521-BF5D-F3858174268A@sandoe.co.uk> <94D29D3A-F402-4844-AA80-F75E9EDBDB0A@andric.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[libcc1plugin.cc:url,suse.de:email,andric.com:email,gnu.org:url,libcp1plugin.cc:url]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[gnu.org:url,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[andric.com,gmail.com,gentoo.org,gcc.gnu.org]; BAYES_HAM(-3.00)[100.00%] X-Spam-Score: -3.10 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Mar 2024, Iain Sandoe wrote: > Hi Dimitry, folks, > > > On 6 Mar 2024, at 23:02, Dimitry Andric wrote: > > > > On 6 Mar 2024, at 15:57, FX Coudert wrote: > >> > >>> Hmm I recall trying it and finding a problem - was there some different fix applied > >>> in the end? > >> > >> The bug is still open, I don?t think a patch was applied, and I don?t find any email to the list stating what the problem could be. > > > > The original patch (https://gcc.gnu.org/bugzilla/attachment.cgi?id=56010) still applies to the master branch. > > I have retested this on various Darwin versions and confirm that it fixes the bootstrap fail on x86_64-darwin23 and works OK on other versions (including 32b hosts). > > +1 for applying this soon. I think it's an obvious change ... Richard. > ==== > > the second patch really needs to be posted separately to make review easier (if we were not in stage 4, I?d say it?s ?obvious? anyway). > > thanks > Iain > > > > It turned out there is also a related problem in libcc1plugin.cc and libcp1plugin.cc , which is fixed by https://gcc.gnu.org/bugzilla/attachment.cgi?id=57639 : > > > > commit 49222b98ac8e30a4a042ada0ece3d7df93f049d2 > > Author: Dimitry Andric > > Date: 2024-03-06T23:46:27+01:00 > > > > Fix libcc1plugin and libc1plugin to use INCLUDE_VECTOR before including > > system.h, instead of directly including , to avoid running into > > poisoned identifiers. > > > > diff --git a/libcc1/libcc1plugin.cc b/libcc1/libcc1plugin.cc > > index 72d17c3b81c..e64847466f4 100644 > > --- a/libcc1/libcc1plugin.cc > > +++ b/libcc1/libcc1plugin.cc > > @@ -32,6 +32,7 @@ > > #undef PACKAGE_VERSION > > > > #define INCLUDE_MEMORY > > +#define INCLUDE_VECTOR > > #include "gcc-plugin.h" > > #include "system.h" > > #include "coretypes.h" > > @@ -69,8 +70,6 @@ > > #include "gcc-c-interface.h" > > #include "context.hh" > > > > -#include > > - > > using namespace cc1_plugin; > > > > > > diff --git a/libcc1/libcp1plugin.cc b/libcc1/libcp1plugin.cc > > index 0eff7c68d29..da68c5d0ac1 100644 > > --- a/libcc1/libcp1plugin.cc > > +++ b/libcc1/libcp1plugin.cc > > @@ -33,6 +33,7 @@ > > #undef PACKAGE_VERSION > > > > #define INCLUDE_MEMORY > > +#define INCLUDE_VECTOR > > #include "gcc-plugin.h" > > #include "system.h" > > #include "coretypes.h" > > @@ -71,8 +72,6 @@ > > #include "rpc.hh" > > #include "context.hh" > > > > -#include > > - > > using namespace cc1_plugin; > > > > > > > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)