public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org,  Jonathan Yong <10walls@gmail.com>,
	 Jan Hubicka <hubicka@ucw.cz>,
	 Richard Biener <richard.guenther@gmail.com>,
	Alexander Monakov <amonakov@ispras.ru>
Subject: Re: [PATCH] libgcov: Call __builtin_fork instead of fork
Date: Fri, 08 Dec 2023 16:28:26 +0100	[thread overview]
Message-ID: <874jgsg1d1.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <ZXMjDO8EIEFZBW/5@tucnak> (Jakub Jelinek's message of "Fri, 8 Dec 2023 15:07:08 +0100")

* Jakub Jelinek:

> On Sat, Dec 02, 2023 at 01:43:22PM +0100, Florian Weimer wrote:
>> Some targets do not provide a prototype for fork, and compilation now
>> fails with an implicit-function-declaration error.
>> 
>> libgcc/
>> 
>> 	* libgcov-interface.c (__gcov_fork):
>
> Description missing (Use __builtin_fork instead of fork.).
>
> Ok with that change.

Fixed & pushed, thanks.

Florian


      reply	other threads:[~2023-12-08 15:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02 12:43 Florian Weimer
2023-12-08 14:07 ` Jakub Jelinek
2023-12-08 15:28   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jgsg1d1.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=10walls@gmail.com \
    --cc=amonakov@ispras.ru \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=jakub@redhat.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).