Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

[Thomas Schwinge <thomas@codesourcery.com>]

Hi Florian!

On 2023-11-13T14:10:34+0100, Florian Weimer <fweimer@redhat.com> wrote:
> --- a/gcc/c/c-typeck.cc
> +++ b/gcc/c/c-typeck.cc

> @@ -7616,27 +7639,28 @@ convert_for_assignment (location_t location, location_t expr_loc, tree type,

>         case ic_assign:
> -         pedwarn (location, OPT_Wint_conversion,
> -                  "assignment to %qT from %qT makes pointer from integer "
> -                  "without a cast", type, rhstype);
> +         pedpermerror (location, OPT_Wint_conversion,
> +                       "assignment to %qT from %qT makes pointer from "
> +                       "integer without a cast", type, rhstype);
>           break;

In addition to the many ones that you've fixed, there's one more:

    [-PASS:-]{+FAIL:+} gcc.dg/graphite/pr83126.c (test for excess errors)

    [...]/testsuite/gcc.dg/graphite/pr83126.c: In function 'ew':
    [...]/testsuite/gcc.dg/graphite/pr83126.c:15:10: error: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion]

Presumably your testing didn't have Graphite enabled due to missing
host libisl?  However, you should be able to reproduce without that:

    $ build-gcc/gcc/xgcc -Bbuild-gcc/gcc/ source-gcc/gcc/testsuite/gcc.dg/graphite/pr83126.c
    source-gcc/gcc/testsuite/gcc.dg/graphite/pr83126.c: In function ‘ew’:
    source-gcc/gcc/testsuite/gcc.dg/graphite/pr83126.c:15:10: error: assignment to ‘int *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
       15 |       fd = *fd;
          |          ^

I'm not proposing a patch as I don't know whether you'd like to just
silence the diagnostic, fix (?) the test case, and/or add another
'dg-error'-checking test case?  (I've not yet looked at the history of
the test case.)


Grüße
 Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955