From: Andreas Schwab <schwab@linux-m68k.org>
To: Martin Jambor <mjambor@suse.cz>
Cc: Robin Dapp <rdapp.gcc@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
jeffreyalaw <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] Fix configure script comments(!?!)
Date: Mon, 06 Nov 2023 18:22:16 +0100 [thread overview]
Message-ID: <874jhyokzb.fsf@igel.home> (raw)
In-Reply-To: <4024.02865454263$1699290221@news.gmane.org> (Martin Jambor's message of "Mon, 06 Nov 2023 18:03:05 +0100")
On Nov 06 2023, Martin Jambor wrote:
> Following this commit, our buildbot script which checks that configure
> scripts where re-generated correctly is unhappy because it insists
> comments are wrong, it wants to them to be like this:
>
> ------------------------------------------------------------
> diff --git a/gcc/configure b/gcc/configure
> index 4d0357cbc28..0d818ae6850 100755
> --- a/gcc/configure
> +++ b/gcc/configure
> @@ -20000,7 +20000,7 @@ else
> lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
> lt_status=$lt_dlunknown
> cat > conftest.$ac_ext <<_LT_EOF
> -#line 19995 "configure"
> +#line 20003 "configure"
> #include "confdefs.h"
>
> #if HAVE_DLFCN_H
> @@ -20106,7 +20106,7 @@ else
> lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
> lt_status=$lt_dlunknown
> cat > conftest.$ac_ext <<_LT_EOF
> -#line 20101 "configure"
> +#line 20109 "configure"
> #include "confdefs.h"
>
> #if HAVE_DLFCN_H
> ------------------------------------------------------------
>
> I'm not sure what that means, whether a wrong version of
> autoconf/automake was used (though when I accidentally tried that, it
> has always complained loudly) or if some environment difference can
> cause this.
This can happen if commits were rebased without re-generating configure
scripts.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2023-11-06 17:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 20:45 [PATCH] genemit: Split insn-emit.cc into ten files Robin Dapp
2023-10-13 6:58 ` Tamar Christina
2023-10-13 15:14 ` Robin Dapp
2023-10-13 15:22 ` Tamar Christina
2023-10-13 15:26 ` Robin Dapp
2023-10-16 10:17 ` Robin Dapp
2023-10-16 10:26 ` Sam James
2023-10-17 6:01 ` Sam James
2023-10-17 7:04 ` Robin Dapp
2023-10-19 15:24 ` Jeff Law
2023-10-27 19:04 ` Robin Dapp
2023-10-30 21:11 ` Jeff Law
2023-11-06 17:03 ` [PATCH] Fix configure script comments(!?!) (Was: Re: [PATCH] genemit: Split insn-emit.cc into ten files) Martin Jambor
2023-11-07 17:52 ` [PATCH] gcc/configure: Regenerate Martin Jambor
[not found] ` <4024.02865454263$1699290221@news.gmane.org>
2023-11-06 17:22 ` Andreas Schwab [this message]
[not found] ` <65491c4b.c20a0220.ca223.f434SMTPIN_ADDED_BROKEN@mx.google.com>
2023-11-06 17:41 ` [PATCH] Fix configure script comments(!?!) (Was: Re: [PATCH] genemit: Split insn-emit.cc into ten files) Robin Dapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jhyokzb.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=mjambor@suse.cz \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).